After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642192 - Correct annotations for st_theme_node_get_content_box()
Correct annotations for st_theme_node_get_content_box()
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Florian Müllner
gnome-shell-maint
Depends on:
Blocks: 641881
 
 
Reported: 2011-02-12 21:37 UTC by Owen Taylor
Modified: 2011-02-12 22:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Correct annotations for st_theme_node_get_content_box() (1.08 KB, patch)
2011-02-12 21:37 UTC, Owen Taylor 		accepted-commit_now Details | Review
StThemeNode: Add (out caller-annotates) annotations (2.11 KB, patch)
2011-02-12 22:06 UTC, Owen Taylor 		committed Details | Review

Description Owen Taylor 2011-02-12 21:37:13 UTC 
Mark the return as (out caller-allocate) so we can use it from JS.
Comment 1 Owen Taylor 2011-02-12 21:37:16 UTC 
Created attachment 180734 [details] [review]
Correct annotations for st_theme_node_get_content_box()
Comment 2 Florian Müllner 2011-02-12 21:47:55 UTC 
Review of attachment 180734 [details] [review]:

Sure. Might be worth annotating the similar st_theme_node_get_paint_box() and st_theme_node_get_background_paint_box().
Comment 3 Owen Taylor 2011-02-12 22:06:55 UTC 
Created attachment 180741 [details] [review]
StThemeNode: Add (out caller-annotates) annotations

Mark the ClutterActorBox return for a number of functions so we can use
them from Javascript.
Comment 4 Florian Müllner 2011-02-12 22:14:12 UTC 
Review of attachment 180741 [details] [review]:

Thanks!
Comment 5 Owen Taylor 2011-02-12 22:31:45 UTC 
Attachment 180741 [details] pushed as 69d25c9 - StThemeNode: Add (out caller-annotates) annotations