After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642165 - Sliders do not match the mockups
Sliders do not match the mockups
Status: RESOLVED FIXED
Product: gnome-themes-standard
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-themes-standard-maint
gnome-themes-standard-maint
Depends on: 643685
Blocks:
 
 
Reported: 2011-02-12 12:06 UTC by Allan Day
Modified: 2011-03-04 19:40 UTC
See Also:
GNOME target: 3.0
GNOME version: ---



Description Allan Day 2011-02-12 12:06:39 UTC
Mockups: http://gitorious.org/gnome-design/gnome-design/blobs/master/mockups/theming/widget-factory.png

The current state is displayed in the attached screenshot.

Both the trough and the handle require styling changes.
Comment 1 Jakub Steiner 2011-02-17 13:29:47 UTC
http://gitorious.org/gnome-design/gnome-design/blobs/master/mockups/theming/widget-dissect-gtkscrollbar.png

Shows all the states.

One particular detail to note is that the padded left side of the trough is 2px while the right side is 1px. This is due to the border around the scrolled view adding that extra pixel. With symmetric trough, the perception is that it is not centred.
Comment 2 Bastien Nocera 2011-03-02 16:47:38 UTC
The 2 main things are:
- the pointy sliders's square part should be centered on the trough.
- when the GtkScale widget has no marks, or marks in different positions, the round slider should be used.

Latest asset:
http://gitorious.org/gnome-design/gnome-design/blobs/master/mockups/theming/widget-dissect-slider.png

GTK_STYLE_CLASS_SCALE_HAS_MARKS_ABOVE and GTK_STYLE_CLASS_SCALE_HAS_MARKS_BELOW are in bug 643685
Comment 3 Cosimo Cecchi 2011-03-04 08:06:20 UTC
This is fixed in master now.
Comment 4 Bastien Nocera 2011-03-04 11:49:12 UTC
Not quite.

The square part of the slider tapers into the pointy bit on the trough, instead of just below, and the square part is still slightly too high.
Comment 5 Cosimo Cecchi 2011-03-04 19:40:35 UTC
I pushed a couple more fixes to master, should match the mockup precisely now.