After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642117 - dnd: Fix bug in computation of snap-back position
dnd: Fix bug in computation of snap-back position
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Florian Müllner
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-02-11 17:27 UTC by Owen Taylor
Modified: 2011-02-11 18:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dnd: Fix bug in computation of snap-back position (1.55 KB, patch)
2011-02-11 17:27 UTC, Owen Taylor 		committed Details | Review

Description Owen Taylor 2011-02-11 17:27:29 UTC 
We were properly accounting for the fact that an ancestor of the
parent could be scaled rather than the parent itself when computing
the snap-back scale, but directly using parent.scale_x for the
snap-back location.
Comment 1 Owen Taylor 2011-02-11 17:27:31 UTC 
Created attachment 180671 [details] [review]
dnd: Fix bug in computation of snap-back position
Comment 2 Owen Taylor 2011-02-11 17:39:02 UTC 
Oops, accidentally pushed this. I'm pretty confident of the change but feel free to
give it a post-mortem review.

Attachment 180671 [details] pushed as 75f771d - dnd: Fix bug in computation of snap-back position
Comment 3 Florian Müllner 2011-02-11 18:02:28 UTC 
Review of attachment 180671 [details] [review]:

Ha! I must be the fasted reviewer on earth, approving a patch before actually noticing the assignment ... but yeah, patch looks good.