After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642072 - unlock dialog does not have layout indicator
unlock dialog does not have layout indicator
Status: RESOLVED FIXED
Product: gnome-screensaver
Classification: Deprecated
Component: dialog
2.91.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-screensaver maintainers
gnome-screensaver maintainers
Depends on:
Blocks:
 
 
Reported: 2011-02-11 00:25 UTC by Sergey V. Udaltsov
Modified: 2011-08-11 23:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (1.23 KB, patch)
2011-07-19 09:12 UTC, Victor Antonovich
none Details | Review

Description Sergey V. Udaltsov 2011-02-11 00:25:29 UTC
In gnome 2.32 the unlock dialog contained the layout indicator. So it was immediately clear what layout is being used for the password entry.
In gnome 2.91.x that indicator is lost. Very uncomfortable for ppl with >1 kbd layouts configured
Comment 1 Antoine Jacoutot 2011-06-07 20:33:47 UTC
Is there any news regarding this? I'm seeing the same issue on both Fedora and OpenBSD. gnome-screensaver is compiled using '--with-kbd-layout-indicator' but the unlock screen still does not display any indicator...
Comment 2 Sergey V. Udaltsov 2011-06-12 19:46:26 UTC
The option --with-...indicator is void now. The code that used the indicator is removed, for some reason. So the primary question is if the maintainer wants it at all.
Comment 3 Victor Antonovich 2011-07-19 09:12:35 UTC
Created attachment 192232 [details] [review]
Proposed patch

Small patch which brings keyboard layout indicator back to unlock dialog.
Comment 4 Antoine Jacoutot 2011-07-19 13:12:36 UTC
(In reply to comment #3)
> Created an attachment (id=192232) [details] [review]
> Proposed patch
> 
> Small patch which brings keyboard layout indicator back to unlock dialog.

Thanks, this seems to work fine :-)
Comment 5 Sergey V. Udaltsov 2011-08-11 23:31:21 UTC
Tested the patch, seems fine, committed.