After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642067 - Add a "session-name" property which specifies which session to use
Add a "session-name" property which specifies which session to use
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Blocks: 642068
 
 
Reported: 2011-02-10 22:43 UTC by Colin Walters
Modified: 2011-02-14 15:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add a "session-name" property which specifies which session to use (4.85 KB, patch)
2011-02-10 22:43 UTC, Colin Walters 		none Details | Review
Add gnome-session.pc (1.95 KB, patch)
2011-02-11 05:11 UTC, Colin Walters 		none Details | Review
Add a "session-name" property which specifies which session to use (7.82 KB, patch)
2011-02-11 05:12 UTC, Colin Walters 		accepted-commit_now Details | Review

Description Colin Walters 2011-02-10 22:43:44 UTC 
Currently we have two sessions:

"gnome"
"gnome-fallback"

This adds a GSetting which allows choosing between these, and
potentially any arbitrary .desktop file that a fork or embed may
write.

This key will be toggled by gnome-control-center to implement
the "always fall back" preference.
Comment 1 Colin Walters 2011-02-10 22:43:45 UTC 
Created attachment 180623 [details] [review]
Add a "session-name" property which specifies which session to use
Comment 2 Colin Walters 2011-02-11 05:11:45 UTC 
Created attachment 180634 [details] [review]
Add gnome-session.pc

gnome-control-center at least will be manipulating some of
the session schema, so we need the ability to express a
hard dependency.
Comment 3 Colin Walters 2011-02-11 05:12:03 UTC 
Created attachment 180635 [details] [review]
Add a "session-name" property which specifies which session to use

Compile tested now =)
Comment 4 Matthias Clasen 2011-02-11 19:50:52 UTC 
 the description of the key should probably mention what the keys are referring to (desktop files in /usr/share/gnome-session/sessions) and what happens if the file is not found
Comment 5 Vincent Untz 2011-02-13 12:03:05 UTC 
Review of attachment 180635 [details] [review]:

If gnome-control-center will work on the schema, then the key should be added to gsettings-desktop-schemas, in org.gnome.desktop.session.gschema.xml.

Apart from that, the patch is fine. So please add the key to gsettings-desktop-schemas and commit the code changes here.

Thanks!
Comment 6 Alexander Larsson 2011-02-14 15:33:44 UTC 
commited.