GNOME Bugzilla – Bug 642036
No way to pass a message when adding a contact
Last modified: 2011-02-14 22:38:42 UTC
When adding a new contact, Empathy uses folks_individual_aggregator_add_persona_from_details() and if I understand this code correctly, we don't have API to pass a message when doing so. This can be used if we want to add UI to let user type a small presentation message.
We'll be breaking that API in this release cycle already (with bug #629078), so now would be a good time to fix this as well.
Could a message not be passed in via the "details" hash table? That said, for consistency with the other methods in IndividualAggregator, having it take a "string? details" would be better.
Created attachment 180862 [details] [review] Add support for passing messages to personas being added After discussing this with Travis on IRC, it was decided to go with using a "message" key in the hash table, rather than breaking API. Here's a branch which documents that, and adds (untested) support for it in the Telepathy backend. http://git.collabora.co.uk/?p=user/pwith/folks;a=shortlog;h=refs/heads/642036-add-persona-message
Argh, and once more I forget to update the NEWS file.
Reviewed by Travis on IRC. commit d4ec25154f72711c9c1e5e81f224051ab12c5e82 Author: Philip Withnall <philip.withnall@collabora.co.uk> Date: Mon Feb 14 22:18:36 2011 +0000 Bug 642036 — No way to pass a message when adding a contact Document that the "message" key in the details hash table passed to IndividualAggregator.add_persona_from_details() may (by convention) be used to pass a human-readable message to the persona being added. Implement this in the Telepathy backend. Closes: bgo#642036 backends/telepathy/lib/tp-lowlevel.c | 5 +++-- backends/telepathy/lib/tp-lowlevel.h | 9 +++++++++ backends/telepathy/lib/tpf-persona-store.vala | 22 ++++++++++++++-------- folks/individual-aggregator.vala | 1 + 4 files changed, 27 insertions(+), 10 deletions(-)