Created attachment 181203 [details] [review]
http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/champlain-642010

 configure.ac                               |    9 +--
 libempathy-gtk/empathy-contact-widget.c    |   15 ++--
 libempathy-gtk/empathy-individual-widget.c |   29 ++++-----
 src/empathy-map-view.c                     |   96 +++++++++++++---------------
 4 files changed, 68 insertions(+), 81 deletions(-)

Jiri: could you please take a look on this branch and let me know if it seems good to you? Thanks!

Great! You saved me a lot of work, the patch looks really good. Unfortunately I couldn't test it because I get some strange linker errors when building empathy with jhbuild. Two minor comments:

1. Just yesterday I introduced champlain_marker_layer_new() which defaults to CHAMPLAIN_SELECTION_NONE so you can use it instead of _new_full() and save a few characters.

2. Instead of getting the bounding box of the layer and calling champlain_view_ensure_visible() you can use champlain_view_ensure_layers_visible() which does the same for all inserted layers.

Thanks for your work!

Thanks for the review. I made these 2 changes and merged the branch. Any plan to make a champlain release soon btw?

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.

(In reply to comment #4)
> Thanks for the review. I made these 2 changes and merged the branch. Any plan
> to make a champlain release soon btw?

0.9.0 is out, see our mailing list.