Created attachment 180553 [details] [review]
MessageTray: fix showing and hiding summary notifications when summary items are clicked

This patch fixes the summary notification reappearing if you click on the
summary item to hide it and hover away. It also ensures that when you click
on any summary item which doesn't correspond to the summary notification
being shown, a new summary notification will replace it right away.

What used to happen is that we'd unset the clicked item in _unlock() that
was called when the focus was ungrabbed because the user clicked outside
of the summary notification, but then would have this._clickedSummaryItem
be null in _onSummaryItemClicked() , and set it to the clicked item all
over again. This patch ensures that we unset the clicked item only when
it is necessary.

We also needed to add the code to call _updateState() again to show a new
summary notification when a previous one was hidden, but
this._clickedSummaryItem was set.

Comment on attachment 180553 [details] [review]
MessageTray: fix showing and hiding summary notifications when summary items are clicked

>+        this._focusGrabber.connect('button-pressed', Lang.bind(this,
>+           function(focusGrabber, source) {

This seems to be doing a lot more work than it needs. Given that ungrabFocus will no longer call _unsetClickedSummaryItem, it seems that all we need to do here is:

                 if (this._clickedSummaryItem && !this._clickedSummaryItem.actor.contains(source))
                     this._unsetClickedSummaryItem();
                 this._focusGrabber.ungrabFocus();
             }));

If the user clicks on the currently-selected summary item, we leave _clickedSummaryItem set (and so _onSummaryItemClicked will do the right thing). Otherwise we clear it. Either way, we ungrab.

Created attachment 180954 [details] [review]
MessageTray: fix showing and hiding summary notifications when summary items are clicked

This patch fixes the summary notification reappearing if you click on the
summary item to hide it and hover away. It also ensures that when you click
on any summary item which doesn't correspond to the summary notification
being shown, a new summary notification will replace it right away.

What used to happen is that we'd unset the clicked item in _unlock() that
was called when the focus was ungrabbed because the user clicked outside
of the summary notification, but then would have this._clickedSummaryItem
be null in _onSummaryItemClicked() , and set it to the clicked item all
over again. This patch ensures that we unset the clicked item only when
it is necessary.

We also needed to add the code to call _updateState() again to show a new
summary notification when a previous one was hidden, but
this._clickedSummaryItem was set.