GNOME Bugzilla – Bug 641871
[gstvorbistag] report date/time tag using GST_TAG_DATE_TIME
Last modified: 2012-07-14 13:03:04 UTC
Currently elements reporting vorbis-comment based tags like flacdec do only emit date information as a GST_TAG_DATE tag. It would be good to report full date/time information (if available) using the recently added GST_TAG_DATE_TIME tag. Example of date/time strings that should be reported: - using default (local) timezone: DATE=2011-01-19 20:33 DATE=2011-01-19 20:33:45 DATE=2011-01-19T20:33:45.123456 - using a specific timezone: DATE=2011-01-19 20:33Z DATE=2011-01-19T20:33:45Z DATE=2011-01-19T20:33:45+01:00
Created attachment 180416 [details] [review] gstvorbistag: Add date/time support Added patch that implements date/time support for vorbis-comment date tags. Followed the existing code style which uses strtoul() for string parsing. Not sure if it would be better to rewrite the code using sscanf().
Created attachment 180418 [details] [review] gstvorbistag: Add date/time support
Comment on attachment 180418 [details] [review] gstvorbistag: Add date/time support Accidentally attached an old patch. This patch has support for parsing microseconds and performs some validity check before creating the GstDateTime instance.
Hrm, sorry, I wasn't aware of or had forgotten about this patch. In any case, it's fixed in git master (0.11/1.0) now: commit bc94374a8f28e3386161c401a25a88d818a70bb9 Author: Oleksij Rempel <bug-track@fisher-privat.net> Date: Wed Jun 27 16:25:06 2012 +0200 vorbistag: store DATE tag in GST_TAG_DATE_TIME instead of GST_TAG_DATE The DATE field may contain dates, partial dates, or dates with time. Store the result in GST_TAG_DATE_TIME, so we can express properly which fields are present or not, and can store the time if there is one, and can serialise and deserialise the tag without loss of information and without making up information that's not there. Instead of using short YYYY-MM-DD form we will store long YYYY-MM-DDTHH:MM:SS+TS date and time. According to this documentation we can do it: http://wiki.xiph.org/VorbisComment#Date_and_time This datetime format is needed by apps where more information is needed. For example voice, meeting recording, etc. https://bugzilla.gnome.org/show_bug.cgi?id=677712