GNOME Bugzilla – Bug 641780
Incorrect C function names for URLable interface
Last modified: 2011-02-08 23:46:26 UTC
The URLable interface generates the following C function declarations: GList* folks_ur_lable_get_urls (FolksURLable* self); void folks_ur_lable_set_urls (FolksURLable* self, GList* value);
I can think of two options: • Rename URLable → Urlable. • Use some [CCode (cname = "…")] magic on the URLable interface or its methods to fix them. I suspect the first option is the best; it's less fragile and makes the interface name more consistent with similar existing APIs (such as SexyUrlLabel, EUrl and CamelUrlScanner; but strangely not CamelURL).
(In reply to comment #1) > I can think of two options: > • Rename URLable → Urlable. This option sounds the best to me as well. I'd like to keep the CCode decorators to a minimum (so the translation between the Vala and C API is as straightforward as possible).
Created attachment 180347 [details] [review] Rename URLable to Urlable http://git.collabora.co.uk/?p=user/pwith/folks;a=shortlog;h=refs/heads/641780-rename-urlable
Review of attachment 180347 [details] [review]: Looks good.
Comment on attachment 180347 [details] [review] Rename URLable to Urlable Decided I needed this in place now, so I've merged it. =========== commit 034ab81aee5219d70927c9c72b7405b4bf4863c3 Author: Philip Withnall <philip.withnall@collabora.co.uk> Date: Mon Feb 7 22:45:35 2011 +0000 Bug 641780 <E2><80><94> Incorrect C function names for URLable interface Rename the new URLable interface to Urlable, as Vala was choking on the capitalisation and producing weird C function names like folks_ur_lable_get_urls(). Closes: bgo#641780 NEWS | 2 ++ folks/individual.vala | 4 ++-- folks/urlable.vala | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-)