After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 641754 - preview widget resizes
preview widget resizes
Status: RESOLVED OBSOLETE
Product: gnome-control-center
Classification: Core
Component: Background
git master
Other All
: Normal minor
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-02-07 17:46 UTC by Jakub Steiner
Modified: 2012-08-22 13:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch (1.13 KB, patch)
2012-04-03 19:30 UTC, Zan Dobersek
none Details | Review

Description Jakub Steiner 2011-02-07 17:46:29 UTC
Depending on the type of wallpaper, the preview monitor gets scaled and generally moves around the page. 

It would feel more polished to keep the monitor static so some whitespace should be added to accomodate the lack of gradient color pickers or "changes throughout the day" label.

To reproduce, just pick a few wallpapers from the thumbnails in the "Wallpapers" section. As soon as you pick one of those animated ones, the preview monitor shrinks and jumps. Similar thing happens for gradients. 

In addition the background behind the monitor itself should not be white, but the same shade of grey as the default bg.
Comment 1 Bastien Nocera 2011-02-11 16:17:19 UTC
The gray background problem is a theme problem, see:
https://bugzilla.gnome.org/show_bug.cgi?id=642112
Comment 2 Robert Roth 2011-07-08 13:33:32 UTC
I can not reproduce this with gnome control center 3.1.3, the preview monitor did not change at all while changing wallpapers, wallpaper types, etc. The "changes throughout the day" and the color pickers appear below the preview widget in the whitespace area, without resizing or changing anything, and the background of the monitor is grey as the default bg for me, so I guess this should be set as FIXED.
Comment 3 Zan Dobersek 2012-04-03 19:26:20 UTC
This still occurs when switching from and to a gradient background source in trunk, using the Adwaita theme. The problem is the icon in the swap-colors-button, it is large enough to cause the bottom hbox to grow. This can be avoided by either setting a height request to the bottom hbox or shrinking the mentioned icon.

I'll upload a patch for the first options in a moment for comments and perhaps a review.
Comment 4 Zan Dobersek 2012-04-03 19:30:14 UTC
Created attachment 211246 [details] [review]
Patch

Sets the height of the bottom hbox to 32 pixels to avoid resizing of the bottom hbox and subsequently the preview widget.
Comment 5 Bastien Nocera 2012-08-22 13:28:39 UTC
This doesn't happen anymore since the background selection panel got redesigned.