After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 641728 - Boxpointer arrows should be "real" content centered
Boxpointer arrows should be "real" content centered
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal minor
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-02-07 15:04 UTC by Quentin "Sardem FF7" Glidic
Modified: 2011-02-09 17:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Centering the boxpointer arrow on the "real" source center (2.04 KB, patch)
2011-02-07 15:04 UTC, Quentin "Sardem FF7" Glidic 		needs-work Details | Review
Centering the boxpointer arrow on the "real" source center (2.13 KB, patch)
2011-02-09 17:23 UTC, Quentin "Sardem FF7" Glidic 		committed Details | Review

Description Quentin "Sardem FF7" Glidic 2011-02-07 15:04:48 UTC 
Created attachment 180306 [details] [review]
Centering the boxpointer arrow on the "real" source center

When a boxpointer source is not padding centered, the arrow is not on the "visual center". It should use the real content to compute the center.
Comment 1 Dan Winship 2011-02-09 14:38:05 UTC 
Comment on attachment 180306 [details] [review]
Centering the boxpointer arrow on the "real" source center

>+        let sourceChild = sourceActor.get_child();

No, this is just assuming that (a) sourceActor has padding, (b) sourceActor is an St.Bin, (c) its child does not have padding.

Did what we discussed on IRC (using st_theme_node_get_content_box()) not work?

Another possibility would be to just make the message tray pass the inner actor as the sourceActor instead of the outer, padded one.
Comment 2 Quentin "Sardem FF7" Glidic 2011-02-09 17:23:49 UTC 
Created attachment 180491 [details] [review]
Centering the boxpointer arrow on the "real" source center

Just needed a little introspection add to mark an argument as (out).
Comment 3 Dan Winship 2011-02-09 17:50:22 UTC 
committed (with a rewritten commit message). thanks