After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 641677 - Full-screen gnome-terminal and empty workspaces causes panel to be hidden.
Full-screen gnome-terminal and empty workspaces causes panel to be hidden.
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
2.91.x
Other Linux
: Normal minor
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 641847 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-02-06 20:25 UTC by Brett Witherspoon
Modified: 2011-02-08 20:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
chrome: try find fullscreen windows only on current workspace (1.06 KB, patch)
2011-02-06 21:25 UTC, Maxim Ermilov
accepted-commit_now Details | Review
chrome: try find fullscreen windows only on current workspace (2.65 KB, patch)
2011-02-08 01:07 UTC, Maxim Ermilov
committed Details | Review

Description Brett Witherspoon 2011-02-06 20:25:54 UTC
When one has a fullscreen gnome-terminal on one workspace and all other workspaces are empty the top panel will be hidden from all workspaces and not just the workspace with the fullscreen application. If any of the other workspaces have windows this does not occur.

To reproduce:
1) Fullscreen gnome-terminal in one workspace.
2) Create another workspace with no windows.
3) Switch between workspaces and the panel is hidden on both.

I am not sure if this is a bug with gnome-terminal or gnome-shell.
Comment 1 Maxim Ermilov 2011-02-06 21:25:14 UTC
Created attachment 180250 [details] [review]
chrome: try find fullscreen windows only on current workspace
Comment 2 Dan Winship 2011-02-07 13:51:32 UTC
Comment on attachment 180250 [details] [review]
chrome: try find fullscreen windows only on current workspace

>+                       (win.get_meta_window() && win.get_meta_window().is_on_all_workspaces());

I don't think it's possible for win.get_meta_window() to return null... (or does the MetaWindow get destroyed right away and the MutterWindowActor not until its destroy animation finishes?)

Also, you could get special extra bonus shell hacker points by abstracting out a shell_global_get_current_workspace_actors() (or Main.getCurrentWorkspaceActors) since I know we do this in other places too (most obviously the workspaces display).
Comment 3 Maxim Ermilov 2011-02-08 01:07:46 UTC
Created attachment 180358 [details] [review]
chrome: try find fullscreen windows only on current workspace

Add Main.isWindowActorDisplayedOnWorkspace and Main.getWindowActorsForWorkspace
Comment 4 Jasper St. Pierre (not reading bugmail) 2011-02-08 17:15:58 UTC
*** Bug 641847 has been marked as a duplicate of this bug. ***