After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 641672 - PATCH: Keyboard controls for fine-grained volume adjustment
PATCH: Keyboard controls for fine-grained volume adjustment
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Movie player
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-02-06 19:27 UTC by Frank Dana
Modified: 2011-02-07 01:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to add fine-grained volume control keybindings (1.12 KB, patch)
2011-02-06 19:27 UTC, Frank Dana
none Details | Review

Description Frank Dana 2011-02-06 19:27:57 UTC
Created attachment 180245 [details] [review]
Patch to add fine-grained volume control keybindings

When adjusting volume using the keyboard, I often find that raising or lowering the volume level by 8% is too drastic a change, and I can't seem to hit a "comfortable" volume unless I reach for the mouse.

This simple patch binds the Shift-UpArrow and Shift-DownArrow keys to a volume adjustment of +2% and -2% (respectively), in the spirit of the fine-grained seek controls (Shift-LeftArrow and Shift-RightArrow).

The patch was originally generated against 2.28.6, but I've successfully applied it against the latest Fedora 14 dist sources (2.32.0). Hopefully it'll apply as-is on the current source tree.
Comment 1 Bastien Nocera 2011-02-06 23:48:38 UTC
commit 5be9be414e03bca8741e556474ec9179e084c5f0
Author: Frank Dana <ferdnyc@gmail.com>
Date:   Sun Feb 6 23:47:00 2011 +0000

    main: Allow finer-grained control on volume
    
    When adjusting volume using the keyboard, I often find that raising or
    lowering the volume level by 8% is too drastic a change, and I can't
    seem to hit a "comfortable" volume unless I reach for the mouse.
    
    We now bind the Shift-UpArrow and Shift-DownArrow keys to a
    volume adjustment of +2% and -2% (respectively), in the spirit of the
    fine-grained seek controls (Shift-LeftArrow and Shift-RightArrow).
    
    https://bugzilla.gnome.org/show_bug.cgi?id=641672
Comment 2 Frank Dana 2011-02-07 01:53:54 UTC
Wow. THAT... was fast! Thanks, Bastien! :)