GNOME Bugzilla – Bug 641662
Update for libfolks API changes to IndividualAggregator.add_persona_from_details
Last modified: 2011-02-18 00:18:25 UTC
+++ This bug was initially created as a clone of Bug #629078 +++ The only thing that stands out to me now (beyond what's covered in bug #639933 and bug #640092) is this function: IndividualAggregator.add_persona_from_details (Folks.Individual? parent, string persona_store_type, string persona_store_id, GLib.HashTable<string,GLib.Value?> details); I think we should replace the persona_store_type and persona_store_id arguments with a PersonaStore argument. Clients can find the PersonaStore on their own via BackendStore.get_backend_by_name(); Backend.persona_stores; and have tighter control over the selection process (which is otherwise too opaque, I think).
Created attachment 180228 [details] [review] Update for libfolks API changes to IndividualAggregator.add_persona_from_details This should be applied to Empathy as soon as a libfolks is released containing attachment #180227 [details] from bug #629078. http://git.collabora.co.uk/?p=user/pwith/empathy;a=shortlog;h=refs/heads/641662-add-persona-from-details
Review of attachment 180228 [details] [review]: ::: libempathy/empathy-individual-manager.c @@ +409,3 @@ + backend_store = folks_backend_store_dup (); + backend = + folks_backend_store_get_backend_by_name (backend_store, "telepathy"); I think that this function should be named folks_backend_store_dup_backend_by_name() instead. We have this convention in tp-glib and it's very handy to know if you have to free/release the result or not.
(In reply to comment #2) > I think that this function should be named > folks_backend_store_dup_backend_by_name() instead. We have this convention in > tp-glib and it's very handy to know if you have to free/release the result or > not. https://bugzilla.gnome.org/show_bug.cgi?id=629078#c29 I'll post an updated patch for Empathy once the folks patch is committed (once the Vala bug is fixed).
Created attachment 180856 [details] [review] Update for libfolks API changes to IndividualAggregator.add_persona_from_details, BackendStore.enabled_backends and BackendStore.get_backend_by_name http://git.collabora.co.uk/?p=user/pwith/empathy;a=shortlog;h=refs/heads/641662-add-persona-from-details-rebase1 Updated patch with the rest of the API changes.
Review of attachment 180856 [details] [review]: Looks good. 2.34 and master please.
Pushed to master: commit d008f215bc41f4e69ff01879047ec946a4370148 Author: Philip Withnall <philip.withnall@collabora.co.uk> Date: Sun Feb 6 12:14:28 2011 +0000 Bug 641662 — Update for libfolks API changes to IndividualAggregator Update EmpathyIndividualManager re. changes to IndividualAggregator.add_persona_from_details, BackendStore.enabled_backends and BackendStore.get_backend_by_name in libfolks. Closes: bgo#641662 libempathy/empathy-individual-manager.c | 33 +++++++++++++++++++++++++++++- libempathy/empathy-utils.c | 2 +- 2 files changed, 32 insertions(+), 3 deletions(-) Pushed to gnome-2-34: commit 6103b13b462a07a8b508ee2223ef1e5acfc8dd47 Author: Philip Withnall <philip.withnall@collabora.co.uk> Date: Sun Feb 6 12:14:28 2011 +0000 Bug 641662 — Update for libfolks API changes to IndividualAggregator Update EmpathyIndividualManager re. changes to IndividualAggregator.add_persona_from_details, BackendStore.enabled_backends and BackendStore.get_backend_by_name in libfolks. Closes: bgo#641662 libempathy/empathy-individual-manager.c | 33 +++++++++++++++++++++++++++++- 1 files changed, 31 insertions(+), 2 deletions(-)