GNOME Bugzilla – Bug 641640
Update autotools configuration
Last modified: 2011-02-14 18:32:40 UTC
Patches following
Created attachment 180201 [details] [review] Remove some obsolete macros
Created attachment 180202 [details] [review] Use AS_HELP_STRING
Created attachment 180203 [details] [review] Use AC_COMPILE_IFELSE
Created attachment 180204 [details] [review] Remove some unneeded checks for glib, pango and atk We use PKG_CHECK_MODULES nowadays, so I think these checks are not needed anymore
Review of attachment 180201 [details] [review]: Looks fine.
Review of attachment 180202 [details] [review]: Looks ok
Review of attachment 180203 [details] [review]: Looks ok
Review of attachment 180204 [details] [review]: I don't think this is quite the same.
Comment on attachment 180202 [details] [review] Use AS_HELP_STRING commit c734bb8e833ba24b7a6ad0db6e67d7b36bd1815a
Comment on attachment 180201 [details] [review] Remove some obsolete macros commit 899019d56ac87e631f1f1e2e592aa58047c109d3
Comment on attachment 180203 [details] [review] Use AC_COMPILE_IFELSE commit 8a965b97867e12f4c08da14b43582faddc36b94e
Created attachment 180252 [details] [review] Use AC_LINK_IFELSE
Created attachment 180253 [details] [review] Use AC_RUN_IFELSE
Created attachment 180254 [details] [review] Use AC_PREPOC_IFELSE
Created attachment 180255 [details] [review] Use AC_EGREP_HEADER
Created attachment 180256 [details] [review] Use AC_CONFIG_COMMANDS
Comment on attachment 180252 [details] [review] Use AC_LINK_IFELSE Looks fine to me
Review of attachment 180253 [details] [review]: Looks fine to me
Review of attachment 180254 [details] [review]: Looks fine
Review of attachment 180255 [details] [review]: For this one, I'd like to find out where we need it first; I can't find it used anywhere in a quick search.
Review of attachment 180256 [details] [review]: Looks fine.
Comment on attachment 180252 [details] [review] Use AC_LINK_IFELSE commit d5872527e5014ffb670b0421cbd5d2ad2fc0f14a
Comment on attachment 180253 [details] [review] Use AC_RUN_IFELSE commit efeade2a06dbf24343a378c9384a2eeaf1739755
Comment on attachment 180254 [details] [review] Use AC_PREPOC_IFELSE commit dffc96a2416f766b02dc5257cb7c8e2c216ef937
Comment on attachment 180256 [details] [review] Use AC_CONFIG_COMMANDS commit 932ab55c65fbb6cb7590512a4f3ae2d2770d0ba5
Created attachment 180770 [details] [review] Remove fd_set checks Yes, seems that we can remove the fd_set checks completely. fd_set was only used in gdk/x11/gxid.c file, that was removed in GTK+ 2.2 Also HAVE_SYS_SELECT_H define is only used in gtk 1.2 http://git.gnome.org/browse/gtk+/tree/gdk/gdk.c?h=gtk-1-2#n36