After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 641640 - Update autotools configuration
Update autotools configuration
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
2.99.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 631656
 
 
Reported: 2011-02-06 02:20 UTC by Javier Jardón (IRC: jjardon)
Modified: 2011-02-14 18:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove some obsolete macros (891 bytes, patch)
2011-02-06 02:22 UTC, Javier Jardón (IRC: jjardon)
committed Details | Review
Use AS_HELP_STRING (8.01 KB, patch)
2011-02-06 02:22 UTC, Javier Jardón (IRC: jjardon)
committed Details | Review
Use AC_COMPILE_IFELSE (5.20 KB, patch)
2011-02-06 02:23 UTC, Javier Jardón (IRC: jjardon)
committed Details | Review
Remove some unneeded checks for glib, pango and atk (3.32 KB, patch)
2011-02-06 02:28 UTC, Javier Jardón (IRC: jjardon)
rejected Details | Review
Use AC_LINK_IFELSE (3.79 KB, patch)
2011-02-06 22:49 UTC, Javier Jardón (IRC: jjardon)
committed Details | Review
Use AC_RUN_IFELSE (1.94 KB, patch)
2011-02-06 22:50 UTC, Javier Jardón (IRC: jjardon)
committed Details | Review
Use AC_PREPOC_IFELSE (859 bytes, patch)
2011-02-06 22:50 UTC, Javier Jardón (IRC: jjardon)
committed Details | Review
Use AC_EGREP_HEADER (900 bytes, patch)
2011-02-06 22:51 UTC, Javier Jardón (IRC: jjardon)
needs-work Details | Review
Use AC_CONFIG_COMMANDS (1.20 KB, patch)
2011-02-06 22:51 UTC, Javier Jardón (IRC: jjardon)
committed Details | Review
Remove fd_set checks (1.40 KB, patch)
2011-02-13 12:18 UTC, Javier Jardón (IRC: jjardon)
committed Details | Review

Description Javier Jardón (IRC: jjardon) 2011-02-06 02:20:53 UTC
Patches following
Comment 1 Javier Jardón (IRC: jjardon) 2011-02-06 02:22:10 UTC
Created attachment 180201 [details] [review]
Remove some obsolete macros
Comment 2 Javier Jardón (IRC: jjardon) 2011-02-06 02:22:49 UTC
Created attachment 180202 [details] [review]
Use AS_HELP_STRING
Comment 3 Javier Jardón (IRC: jjardon) 2011-02-06 02:23:19 UTC
Created attachment 180203 [details] [review]
Use AC_COMPILE_IFELSE
Comment 4 Javier Jardón (IRC: jjardon) 2011-02-06 02:28:37 UTC
Created attachment 180204 [details] [review]
Remove some unneeded checks for glib, pango and atk

We use PKG_CHECK_MODULES nowadays, so I think these checks are not needed anymore
Comment 5 Matthias Clasen 2011-02-06 19:32:55 UTC
Review of attachment 180201 [details] [review]:

Looks fine.
Comment 6 Matthias Clasen 2011-02-06 19:34:56 UTC
Review of attachment 180202 [details] [review]:

Looks ok
Comment 7 Matthias Clasen 2011-02-06 19:36:15 UTC
Review of attachment 180203 [details] [review]:

Looks ok
Comment 8 Matthias Clasen 2011-02-06 19:37:40 UTC
Review of attachment 180204 [details] [review]:

I don't think this is quite the same.
Comment 9 Javier Jardón (IRC: jjardon) 2011-02-06 21:07:05 UTC
Comment on attachment 180202 [details] [review]
Use AS_HELP_STRING

commit c734bb8e833ba24b7a6ad0db6e67d7b36bd1815a
Comment 10 Javier Jardón (IRC: jjardon) 2011-02-06 21:07:26 UTC
Comment on attachment 180201 [details] [review]
Remove some obsolete macros

commit 899019d56ac87e631f1f1e2e592aa58047c109d3
Comment 11 Javier Jardón (IRC: jjardon) 2011-02-06 21:08:13 UTC
Comment on attachment 180203 [details] [review]
Use AC_COMPILE_IFELSE

commit 8a965b97867e12f4c08da14b43582faddc36b94e
Comment 12 Javier Jardón (IRC: jjardon) 2011-02-06 22:49:55 UTC
Created attachment 180252 [details] [review]
Use AC_LINK_IFELSE
Comment 13 Javier Jardón (IRC: jjardon) 2011-02-06 22:50:19 UTC
Created attachment 180253 [details] [review]
Use AC_RUN_IFELSE
Comment 14 Javier Jardón (IRC: jjardon) 2011-02-06 22:50:52 UTC
Created attachment 180254 [details] [review]
Use AC_PREPOC_IFELSE
Comment 15 Javier Jardón (IRC: jjardon) 2011-02-06 22:51:18 UTC
Created attachment 180255 [details] [review]
Use AC_EGREP_HEADER
Comment 16 Javier Jardón (IRC: jjardon) 2011-02-06 22:51:44 UTC
Created attachment 180256 [details] [review]
Use AC_CONFIG_COMMANDS
Comment 17 Matthias Clasen 2011-02-12 16:16:50 UTC
Comment on attachment 180252 [details] [review]
Use AC_LINK_IFELSE

Looks fine to me
Comment 18 Matthias Clasen 2011-02-12 16:17:18 UTC
Review of attachment 180253 [details] [review]:

Looks fine to me
Comment 19 Matthias Clasen 2011-02-12 16:17:49 UTC
Review of attachment 180254 [details] [review]:

Looks fine
Comment 20 Matthias Clasen 2011-02-12 16:30:23 UTC
Review of attachment 180255 [details] [review]:

For this one, I'd like to find out where we need it first; I can't find it used anywhere in a quick search.
Comment 21 Matthias Clasen 2011-02-12 16:31:08 UTC
Review of attachment 180256 [details] [review]:

Looks fine.
Comment 22 Javier Jardón (IRC: jjardon) 2011-02-13 11:38:37 UTC
Comment on attachment 180252 [details] [review]
Use AC_LINK_IFELSE

commit d5872527e5014ffb670b0421cbd5d2ad2fc0f14a
Comment 23 Javier Jardón (IRC: jjardon) 2011-02-13 11:38:54 UTC
Comment on attachment 180253 [details] [review]
Use AC_RUN_IFELSE

commit efeade2a06dbf24343a378c9384a2eeaf1739755
Comment 24 Javier Jardón (IRC: jjardon) 2011-02-13 11:39:19 UTC
Comment on attachment 180254 [details] [review]
Use AC_PREPOC_IFELSE

commit dffc96a2416f766b02dc5257cb7c8e2c216ef937
Comment 25 Javier Jardón (IRC: jjardon) 2011-02-13 11:39:36 UTC
Comment on attachment 180256 [details] [review]
Use AC_CONFIG_COMMANDS

commit 932ab55c65fbb6cb7590512a4f3ae2d2770d0ba5
Comment 26 Javier Jardón (IRC: jjardon) 2011-02-13 12:18:26 UTC
Created attachment 180770 [details] [review]
Remove fd_set checks

Yes, seems that we can remove the fd_set checks completely.

fd_set was only used in gdk/x11/gxid.c file, that was removed in GTK+ 2.2

Also HAVE_SYS_SELECT_H define is only used in gtk 1.2
http://git.gnome.org/browse/gtk+/tree/gdk/gdk.c?h=gtk-1-2#n36