After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 641537 - Overview search entry is to short for its text.
Overview search entry is to short for its text.
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-02-04 19:47 UTC by Ray Strode [halfline]
Modified: 2011-02-04 20:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
css: don't hard code entry height (1.03 KB, patch)
2011-02-04 19:47 UTC, Ray Strode [halfline]
committed Details | Review

Description Ray Strode [halfline] 2011-02-04 19:47:12 UTC
When we switched to Cantarell, the search entry box started
clipping the bottoms of j's, etc.  It needs some size
changes to work with the new font, I think.
Comment 1 Ray Strode [halfline] 2011-02-04 19:47:14 UTC
Created attachment 180106 [details] [review]
css: don't hard code entry height

When commit 961fdd861fac46ef0ecc67bb8be14c0ce828e612 landed
text in the overview search entry field started getting clipped.

This is because the default font size changed but the entry is a
hard coded pixel height.

This commit drops the hard coding, so the entry can automatically
size itself to the proper height.
Comment 2 drago01 2011-02-04 20:03:18 UTC
Review of attachment 180106 [details] [review]:

Looks good, I would include "search" in the subject though i.e s/entry/search entry/
Comment 3 Ray Strode [halfline] 2011-02-04 20:16:22 UTC
Thanks.