After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 641526 - Background should fade in
Background should fade in
Status: RESOLVED FIXED
Product: gnome-desktop
Classification: Core
Component: Background
2.91.x
Other Linux
: Normal normal
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-02-04 18:21 UTC by Cosimo Cecchi
Modified: 2013-03-06 20:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gnome-bg: force property update when doing new crossfade frame (1.85 KB, patch)
2011-02-07 21:03 UTC, Ray Strode [halfline]
committed Details | Review

Description Cosimo Cecchi 2011-02-04 18:21:02 UTC
In 2.x nautilus used to have the fade-in effect from gdm's background to the desktop one. Now that nautilus is not started anymore, we should backport that effect in g-s-d.
Comment 1 Bastien Nocera 2011-02-04 19:16:41 UTC
The problem is also how this would interact with mutter/gnome-shell's startup, as it takes ownership of the "screen".
Comment 2 Owen Taylor 2011-02-04 19:19:59 UTC
My basic feeling is that if we can avoid it, nothing should touch the screen until gnome-shell is running and has redirected the screen. Then arbitrary visual effects and niceness are possible. (May be ambitious for 3.0, not really sure about all the pieces in the startup sequence at the moment)
Comment 3 Tomas Bzatek 2011-02-07 13:22:18 UTC
I think this is somewhat similar to bug 639377
Comment 4 Ray Strode [halfline] 2011-02-07 16:43:02 UTC
g-s-d already has code to do the crossfade effect if nautilus isn't running.

it could be that code isn't working, for whatever reason, though.

If it is broken , we should either fix it or disable it (cf comment 2)
Comment 5 Ray Strode [halfline] 2011-02-07 21:01:46 UTC
So I just commited this patch:

http://git.gnome.org/browse/gnome-settings-daemon/commit/?id=5cb80995b6899c6ed185797333b709ea9342de42

which fixes an unrelated problem I noticed while looking into the issue.
Comment 6 Ray Strode [halfline] 2011-02-07 21:03:01 UTC
Created attachment 180341 [details] [review]
gnome-bg: force property update when doing new crossfade frame

gnome-shell needs to get notified about animation updates.

This commit frobs the property to wake mutter up.
Comment 7 Ray Strode [halfline] 2011-02-07 21:04:23 UTC
After discussion on IRC with owen and cosimo I came up with the above patch. 

Unfortunately, I can't test it, because with or without that patch selecting backgrounds in background capplet makes my X server tank if gnome-shell is running. I haven't figured out the details of why yet.
Comment 8 Owen Taylor 2011-02-07 21:05:03 UTC
Review of attachment 180341 [details] [review]:

::: libgnome-desktop/gnome-bg-crossfade.c
@@ +382,3 @@
+                         gdk_x11_get_xatom_by_name ("_XROOTPMAP_ID"),
+                         XA_PIXMAP, 32, PropModeAppend,
+                         (guchar *) &zero_length_pixmap, 0);

Can't you just pass NULL here? X couldn't dereference this, could it, since the length is zero?
Comment 9 Ray Strode [halfline] 2011-02-16 22:17:59 UTC
Looks like a bunch of dri drawable lifecycle fixes are going in now:

http://lists.x.org/archives/xorg-devel/2011-February/018936.html
Comment 10 Ray Strode [halfline] 2011-02-16 22:19:41 UTC
(In reply to comment #8)
> Review of attachment 180341 [details] [review]:
> 
> ::: libgnome-desktop/gnome-bg-crossfade.c
> @@ +382,3 @@
> +                         gdk_x11_get_xatom_by_name ("_XROOTPMAP_ID"),
> +                         XA_PIXMAP, 32, PropModeAppend,
> +                         (guchar *) &zero_length_pixmap, 0);
> 
> Can't you just pass NULL here? X couldn't dereference this, could it, since the
> length is zero?

Yea, I think so.
Comment 11 André Klapper 2011-03-03 20:52:07 UTC
[Removing GNOME3.0 target as decided in release-team meeting on March 03, 2011. "nice-to-have" categorisation for GNOME3.0]
Comment 12 Matthias Clasen 2011-09-17 22:22:26 UTC
Maybe time to revisit this again, Ray ?
Comment 13 Ray Strode [halfline] 2011-09-19 16:26:53 UTC
probably 3.4 material at this point, which is good, because we definitely don't want to ship a fade effect that will make people with slightly old X servers crash their sessions.
Comment 14 Ray Strode [halfline] 2012-05-08 20:21:33 UTC
fwiw, I just gave this patch a go, and it wasn't sufficient. I didn't dig deeper.
Comment 15 Ray Strode [halfline] 2012-06-07 18:36:46 UTC
Attachment 180341 [details] pushed as 575354e - gnome-bg: force property update when doing new crossfade frame
Comment 16 Ray Strode [halfline] 2012-06-11 14:37:40 UTC
not sure why i pushed the patch that was insufficient and not sure why i closed the bug. reopening.
Comment 17 Matthias Clasen 2013-03-06 20:59:56 UTC
I think this is fixed, with the zoom-in animation we have now.