After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 641484 - [patch] [regression] can't edit bookmarks name anymore
[patch] [regression] can't edit bookmarks name anymore
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Bookmarks
2.91.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-02-04 12:23 UTC by Stefano Teso
Modified: 2011-02-04 21:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (922 bytes, patch)
2011-02-04 12:23 UTC, Stefano Teso 		committed Details | Review

Description Stefano Teso 2011-02-04 12:23:15 UTC 
Created attachment 180075 [details] [review]
proposed patch

bookmark renaming from the places sidebar doesn't work anymore.

due to nautilus-bookmark.c::nautilus_bookmark_class_init calling g_param_spec_boolean with G_PARAM_CONSTRUCT_ONLY, all calls to nautilus_bookmark_set_custom_name print:

(nautilus:15409): GLib-GObject-WARNING **: g_object_set_valist: construct property "custom-name" for object `NautilusBookmark' can't be set after construction

The attached patch removes G_PARAM_CONSTRUCT_ONLY when creating the "name" and "custom-name" properties.
Comment 1 Cosimo Cecchi 2011-02-04 21:24:10 UTC 
Ops, my bad. Pushed to master, thanks for the patch!