After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 641421 - Looks bad when no printers configured
Looks bad when no printers configured
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Printers
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Marek Kašík
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-02-04 00:21 UTC by Bastien Nocera
Modified: 2011-03-21 14:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot (17.45 KB, image/png)
2011-02-04 00:22 UTC, Bastien Nocera
Details
no printers screenshot (18.44 KB, image/png)
2011-02-12 14:58 UTC, Bastien Nocera
Details
no-printer screenshot (10.29 KB, image/png)
2011-03-16 17:06 UTC, Marek Kašík
Details
no-cups screenshot (10.08 KB, image/png)
2011-03-16 17:07 UTC, Marek Kašík
Details

Description Bastien Nocera 2011-02-04 00:21:02 UTC
The treeview is not sized properly, and some of the widgets look like they should be hidden, or disabled.
Comment 1 Bastien Nocera 2011-02-04 00:22:04 UTC
Created attachment 180034 [details]
screenshot
Comment 2 Marek Kašík 2011-02-10 14:44:30 UTC
Hi Bastien,

I've committed patch which sets minimal width of renderer showing names of printers to 120 pixels. It also sets ellipsizing for the renderer and sets some widgets insensitive when there is no printer.
Do you agree with it?

Marek
Comment 3 Bastien Nocera 2011-02-12 14:58:27 UTC
Created attachment 180723 [details]
no printers screenshot

It's much better now, but I'm not sure that showing all those labels (including the printer icon!) is a good idea when there are no printers configured.

Instead, I would expect to see a label mentioning that no printers are configured, and a button allowing me to add a new printer (or ways to get a new printer configured).
Comment 4 Marek Kašík 2011-03-16 17:06:38 UTC
Created attachment 183551 [details]
no-printer screenshot

Hi Bastien,

what about showing something like in the attachment?

Marek
Comment 5 Marek Kašík 2011-03-16 17:07:48 UTC
Created attachment 183552 [details]
no-cups screenshot

Similar message for situation when g-c-c can not connect to CUPS server.
Comment 6 Bastien Nocera 2011-03-16 17:18:18 UTC
The strings need obvious work but the overall look is good.
Comment 7 Marek Kašík 2011-03-17 17:16:46 UTC
What strings do you suggest?
Comment 8 Bastien Nocera 2011-03-17 17:46:56 UTC
For the no printer case:
"No printers configured"
[ Add New Printer ]

For the no cups case:
The printing service (CUPS) is not running, please check with your system administrator.
Comment 9 William Jon McCann 2011-03-17 17:51:07 UTC
[mid air collision]
For the no-printers case:

 * Show a "No printers available" or similar text, insensitive in the left device pane.  Similar to http://live.gnome.org/Design/SystemSettings/Bluetooth
 * Show just a button in the right side, something like "Add a printer"

For the no cups case:
 * Show "No printers available" or similar text, insensitive in the left device pane.  Similar to http://live.gnome.org/Design/SystemSettings/Bluetooth
 * Show text in the right pane, something like "Sorry!  The system printing service doesn't seem to be available." with a sad face icon or something.
Comment 10 Marek Kašík 2011-03-18 13:58:13 UTC
I've committed combination of your comments. It shows "No printer available" in device pane and "Add New Printer" button on the right side when there is no printer configured.
It shows "No printer available" in device pane and "The printing service (CUPS) is not running, please check with your system administrator." in the right side when the CUPS is not running.

Marek
Comment 11 William Jon McCann 2011-03-18 15:43:52 UTC
I don't have a system administrator.  I don't like that text.  Can we please use my suggestion?  Also, jimmac is working on a sad computer icon.

Also it should be "No printers available" instead of "NO printer available".

Thanks.
Comment 12 Marek Kašík 2011-03-18 16:04:35 UTC
(In reply to comment #11)
> I don't have a system administrator.  I don't like that text.  Can we please
> use my suggestion?  Also, jimmac is working on a sad computer icon.
> 
> Also it should be "No printers available" instead of "NO printer available".
> 
> Thanks.

Sorry, I mistyped it in the comment. There is "No printers available".

I've changed the text to your suggestion "Sorry! The system printing
service doesn't seem to be available.".

I'll insert the icon there when it will be available.

Marek
Comment 13 Marek Kašík 2011-03-21 14:55:11 UTC
Hi,

I've added the icon there.

Marek