GNOME Bugzilla – Bug 641416
[PATCH] Can't compile gnote on Fedora 15
Last modified: 2011-03-15 04:38:38 UTC
I gave up after updating boost.m4 from the upstream repo, and adding the ability to detect GCC 4.6.
Created attachment 180031 [details] [review] patch to boost.m4
Created attachment 180032 [details] [review] Update boost.m4 from upstream
The build logs from Fedora showing it's unable to find the boost filesystem libraries: http://koji.fedoraproject.org/koji/getfile?taskID=2759877&name=build.log
Thanks for reporting this. I'll take a look at this soon.
Petr Machata posted a patch to make this build on Fedora 15: http://lists.fedoraproject.org/pipermail/devel/2011-February/148377.html Looks like a lot of the work is in libsigc++ and boost.m4. Given that gnote ships boost.m4 though, I'll leave it to you to figure out how to upstream this.
Created attachment 182050 [details] Patch to fix the issue. Patch to latest boost.m4, fixing this bug.
My test on Fedora rawhide showed the following issues: 1. configure check for boost filesystem fails. 2. The API of boost filesystem changed, causing Gnote compilation errors. No other issues, most likely they were solved outside Gnote and no changed in Gnote are required. As for two issues above: -I have attached a patch for boost.m4, that solves the first. -The second issue for now can be solved by adding -DBOOST_FILESYSTEM_VERSION=2 to CFLAGS. I'll do necessairy code changes in Gnote soon to work with version 3.
Created attachment 182359 [details] [review] Bump required boost version to 1.36 This patch bumps the minimum required version of boost to 1.36. It doesn't seem to be worth to support older ones.
Created attachment 182360 [details] [review] Fix compile with boost 1.46 Make Gnote aware of boost-filesystem version 3, used by default in boost 1.46.
Patches for boost.m4 from this bug have been accepted upstream. I have pushed the newer boost.m4 to master, know only Gnote code related issues left to solve. Proposed solutions attached.
Created attachment 182827 [details] [review] Proposed fix I think it is easier to replace boost::filesystem::path with their Glib equivalents.
Created attachment 183401 [details] [review] Removed a few more instances of Boost usage Gnote should now build on Fedora 15 and Fedora 14.
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.