GNOME Bugzilla – Bug 641405
[vp8enc] patch - allow to use best quality
Last modified: 2011-05-18 11:28:38 UTC
Created attachment 180023 [details] [review] patch - vp8enc_quality.diff v1 The quality setting in vp8enc disable bitrate handling set static quantizer. see this part of code, gstvp8enc.c: cfg.rc_min_quantizer = 63 - encoder->quality * 5.0; cfg.rc_max_quantizer = 63 - encoder->quality * 5.0; Current max quality is 10. vpx allow quantizer range 0-63, This mean 63 - 10 * 5.0 = 13, this make not really good quality. If we allow quality 12.4, this will make quantizer=1, also best possible quality.
Created attachment 180057 [details] [review] patch - vp8enc_quality.diff v2 This patch just shift conversation values to make use of best possible quantizer.
Created attachment 180451 [details] [review] vp8enc_quantizer I desided to replace quality patch with qunatizer patch. This make possible all variations user may wish.
Created attachment 180452 [details] [review] vp8enc_quantizer v2 Forgot to include ext/vp8/gstvp8enc.h to the patch.
The quantize patch should be a part of patch set needed to reproduce setting recommended for realtime encoding and streaming. http://www.webmproject.org/tools/encoder-parameters/ vpxenc input_640_480_15fps.yuv -o output_vp8.webm \ --i420 -w 640 -h 480 -p 1 -t 4 \ --rt --cpu-used=4 --end-usage=cbr --target-bitrate=500 \ --fps=15000/1001 --undershoot-pct=95 \ --buf-sz=6 --buf-initial=4 --buf-optimal=5 -v \ --kf-max-dist=999999 \ --min-q=4 --max-q=56
commit 23f9286d8878070aca565e6d27cb2cc1cbe3a9d1 Author: Sebastian Dröge <sebastian.droege@collabora.co.uk> Date: Wed May 18 13:27:20 2011 +0200 vp8enc: Name max/min quantizer properties {max,min}-quantizer Also improve quality property description. commit 1b650b6486f1c681a3731e3ad2da54c65602247e Author: Alexey Fisher <bug-track@fisher-privat.net> Date: Wed May 18 13:26:23 2011 +0200 vp8enc: Add properties to select a maximum and minimum quantizer Fixes bug #641405. commit a9ea8823078321f275a99efec2be75599d1427fb Author: Alexey Fisher <bug-track@fisher-privat.net> Date: Wed May 18 13:18:58 2011 +0200 vp8enc: Fix quality to (constant) quantizer mapping This now allows to select all possible quantizers between 0 and 63. See bug #641405.