After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 641357 - Remove libdir= from all Makefile.am
Remove libdir= from all Makefile.am
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: plugins
git master
Other Linux
: Normal trivial
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2011-02-03 15:20 UTC by Fabien Lebaillif - Delamare
Modified: 2012-04-03 10:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
remove libdir= (6.80 KB, patch)
2011-02-03 15:20 UTC, Fabien Lebaillif - Delamare 		none Details | Review
plugins: Don't overwrite libdir in Makefile.am (11.60 KB, patch)
2012-03-27 15:07 UTC, Bastien Nocera 		committed Details | Review

Description Fabien Lebaillif - Delamare 2011-02-03 15:20:45 UTC 
Created attachment 179995 [details] [review]
remove libdir=

I have been using this patch for a while now. 

Removing libdir= makes it possible to cross compile and set GRL_PLUGINS_DIR properly, ie solve a problem I had with GRL_PLUGINS_DIR, where it being different during the build/install and at runtime (/tmp/mybuildroot/usr/lib/grilo-0.1 vs /usr/lib/grilo-0.1)


I have tried it with and without cross compilation without a problem.
Comment 1 Juan A. Suarez Romero 2011-02-03 19:45:07 UTC 
Checking it, plugins are installed in the wrong place.

I guess you need to set up GRL_PLUGINS_DIR properly to install it in the right place. If you don't have it, then it should install plugins on default place.

IMO, it would be better to have a --pluginsdir option when configuring plugins, so user can override default place to install plugins.
Comment 2 André Klapper 2012-02-03 13:40:55 UTC 
Comment on attachment 179995 [details] [review]
remove libdir=

[Setting "patch" flag and correcting mime type so this can actually be queried for.]
Comment 3 Bastien Nocera 2012-03-27 15:07:19 UTC 
Created attachment 210706 [details] [review]
plugins: Don't overwrite libdir in Makefile.am
Comment 4 Bastien Nocera 2012-03-27 15:09:55 UTC 
That patch is for 0.1.x. Was fixed in a similar way in master already.
Comment 5 Juan A. Suarez Romero 2012-04-03 10:42:43 UTC 
commit 4f3322ea55a468e51644b527880ef88e2c4a1ce5
Author: Bastien Nocera <hadess@hadess.net>
Date:   Tue Mar 27 17:03:04 2012 +0200

    plugins: Don't overwrite libdir in Makefile.am
    
    https://bugzilla.gnome.org/show_bug.cgi?id=641357

 src/media/apple-trailers/Makefile.am     |    4 ++--
 src/media/bliptv/Makefile.am             |    6 +++---
 src/media/bookmarks/Makefile.am          |    4 ++--
 src/media/filesystem/Makefile.am         |    4 ++--
 src/media/jamendo/Makefile.am            |    4 ++--
 src/media/podcasts/Makefile.am           |    4 ++--
 src/media/shoutcast/Makefile.am          |    4 ++--
 src/media/tracker/Makefile.am            |    4 ++--
 src/media/upnp/Makefile.am               |    4 ++--
 src/media/vimeo/Makefile.am              |    4 ++--
 src/media/youtube/Makefile.am            |    4 ++--
 src/metadata/fake-metadata/Makefile.am   |    4 ++--
 src/metadata/gravatar/Makefile.am        |    4 ++--
 src/metadata/lastfm-albumart/Makefile.am |    4 ++--
 src/metadata/local-metadata/Makefile.am  |    4 ++--
 src/metadata/metadata-store/Makefile.am  |    4 ++--
 16 files changed, 33 insertions(+), 33 deletions(-)