After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 641337 - Unfriendly option "Clear" is at the top in the right-click menu
Unfriendly option "Clear" is at the top in the right-click menu
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Chat
2.32.x
Other Linux
: Normal minor
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2011-02-03 12:08 UTC by noboost
Modified: 2016-07-22 01:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (2.17 KB, patch)
2013-09-07 05:29 UTC, Skyler Hawthorne 		committed Details | Review

Description noboost 2011-02-03 12:08:19 UTC 
In the right-click menu, the seemingly irreversible option "Clear" is first in the list. Whilst being a very trivial (some would say picky) and easy to avoid issue, having the most destructive option in the menu highlighted as soon as the right mouse button is pressed is not entirely friendly and increases the likelihood of accidentally deleting the conversation history. 

I have no idea if there are guidelines for item placement in right-click menus but I would suggest that items such as "Clear" that remove content are placed further down the list (at least not first).
Comment 1 Skyler Hawthorne 2013-09-07 05:29:26 UTC 
Created attachment 254329 [details] [review]
Proposed patch

Here's a patch that moves it to the end of the list.
Comment 2 Guillaume Desmottes 2013-09-09 07:45:20 UTC 
Review of attachment 254329 [details] [review]:

Thanks for the patch. I'll merge it after the 3.10 release as we are now in UI freeze.
Comment 3 André Klapper 2014-05-18 09:59:13 UTC 
(In reply to comment #2)
> Review of attachment 254329 [details] [review]:
> 
> Thanks for the patch. I'll merge it after the 3.10 release as we are now in UI
> freeze.

Will a gnome-3-12 branch and a merge happen at some point?
Comment 4 Michael Catanzaro 2016-07-22 01:52:08 UTC 
(In reply to André Klapper from comment #3)
> Will a gnome-3-12 branch and a merge happen at some point?

Turns out the answer was "yes, in 2016."