After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 641210 - Add interface for postal addresses
Add interface for postal addresses
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: libfolks
git master
Other Linux
: Normal normal
: folks-0.4.0
Assigned To: folks-maint
folks-maint
Depends on: 638279 642513
Blocks:
 
 
Reported: 2011-02-02 01:53 UTC by Travis Reitter
Modified: 2011-03-03 19:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Marco Barisione's patch to add a PostalAddressOwner interface. (6.12 KB, patch)
2011-03-03 17:34 UTC, Raul Gutierrez Segales
none Details | Review
Make the Individual class implement the PostalAddressOwner interface. (3.39 KB, patch)
2011-03-03 17:35 UTC, Raul Gutierrez Segales
none Details | Review
Marco Barisione's patch to add a PostalAddressOwner interface. (6.12 KB, patch)
2011-03-03 19:31 UTC, Raul Gutierrez Segales
none Details | Review
Make the Individual class implement the PostalAddressOwner interface. (3.37 KB, patch)
2011-03-03 19:32 UTC, Raul Gutierrez Segales
none Details | Review

Description Travis Reitter 2011-02-02 01:53:50 UTC
+++ This bug was initially created as a clone of Bug #638279 +++

Folks needs an interface for postal addresses. I'm leaning heavily toward making this an unstructured string which is compatible with all major mapping services and mostly-incompatible with existing address book software (which tends to use the structured ADR vCard field or equivalent).

See bug #638279 for prior discussion.
Comment 1 Travis Reitter 2011-02-02 02:04:26 UTC
This isn't a strict blocker for the new backends.
Comment 2 Philip Withnall 2011-02-14 23:13:45 UTC
Punting to 0.3.7.
Comment 3 Raul Gutierrez Segales 2011-03-03 17:34:35 UTC
Created attachment 182379 [details] [review]
Marco Barisione's patch to add a PostalAddressOwner interface.

I've re-based Marco's patch on master.
Comment 4 Raul Gutierrez Segales 2011-03-03 17:35:20 UTC
Created attachment 182380 [details] [review]
Make the Individual class implement the PostalAddressOwner interface. 

Re-based Marco's patch on master.
Comment 5 Raul Gutierrez Segales 2011-03-03 19:31:57 UTC
Created attachment 182391 [details] [review]
Marco Barisione's patch to add a PostalAddressOwner interface.

Re-based on master.
Comment 6 Raul Gutierrez Segales 2011-03-03 19:32:27 UTC
Created attachment 182392 [details] [review]
Make the Individual class implement the PostalAddressOwner interface.

Re-based on master.
Comment 7 Travis Reitter 2011-03-03 19:54:28 UTC
Thanks -- committed:

commit 244a1d345600320934fdef22ab4d6e3a5943aac5
Author: Travis Reitter <travis.reitter@collabora.co.uk>
Date:   Thu Mar 3 11:50:06 2011 -0800

    Add NEWS entry for postal address interface
    
    Fixes: bgo#641210 - Add interface for postal addresses

 NEWS |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

commit e14a7a0c486edd04971d457af9bdbe101dba3781
Author: Marco Barisione <marco@barisione.org>
Date:   Tue Dec 28 17:28:12 2010 +0100

    Make Individual implement the PostalAddressOwner interface

 folks/individual.vala |   46 ++++++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 46 insertions(+), 0 deletions(-)

commit 290957d2bb89d954078bc862c7ee9a085b6a7326
Author: Marco Barisione <marco@barisione.org>
Date:   Tue Dec 28 17:27:38 2010 +0100

    Add PostalAddressOwner for contacts with postal addresses

 folks/Makefile.am               |    1 +
 folks/postal-address-owner.vala |  189 +++++++++++++++++++++++++++++++++++++++
 2 files changed, 190 insertions(+), 0 deletions(-)