After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 641174 - Run dialog reports all errors as "Command not found"
Run dialog reports all errors as "Command not found"
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Colin Walters
gnome-shell-maint
Depends on: 591480
Blocks:
 
 
Reported: 2011-02-01 18:14 UTC by Owen Taylor
Modified: 2012-06-21 17:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
util: trySpawn throw error with correct message (1.31 KB, patch)
2011-02-14 00:14 UTC, Maxim Ermilov 		needs-work Details | Review

Description Owen Taylor 2011-02-01 18:14:53 UTC 
commit 912a30c5664f18e416a17c031a26cb89123a05d5
Author: William Jon McCann <jmccann@redhat.com>
Date:   Thu Jan 27 15:26:58 2011 -0500

    Clean up the presentation of errors in the run dialog

Added the code:

   if (err.code == GLib.SpawnError.G_SPAWN_ERROR_NOENT) {
       err.message = _("Command not found");
   } else {
       // the old stuff 
   }

But there's no support in gjs for err.code (bug 591480), and the error code is called GLib.SpawnError.NOENT, so this is just undefined == undefined. (Test by 'chmod a-x <some executable you want to run>')
Comment 1 Maxim Ermilov 2011-02-14 00:14:23 UTC 
Created attachment 180795 [details] [review]
util: trySpawn throw error with correct message

( depend on https://bugzilla.gnome.org/show_bug.cgi?id=591480#c6 )
Comment 2 Owen Taylor 2011-07-05 17:28:46 UTC 
Reassigning to walters, since this is all about GJS changes in the end
Comment 3 Jasper St. Pierre (not reading bugmail) 2011-08-03 19:10:17 UTC 
Review of attachment 180795 [details] [review]:

err.code still doesn't exist, so this is incorrect.
Comment 4 Giovanni Campagna 2012-06-07 18:46:13 UTC 
Review of attachment 180795 [details] [review]:

gjs changes merged, re-reviewing.

::: js/misc/util.js
@@ +83,3 @@
                          null, null);
     } catch (err) {
+        if (err.code == GLib.SpawnError.NOENT) {

You need to check "err instanceof GLib.SpawnError" too
Or just use err.matches(GLib.SpawnError, GLib.SpawnError.NOENT)
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-06-21 17:09:20 UTC 
This is fixed now.