GNOME Bugzilla – Bug 641049
Calendar: First day of week issues
Last modified: 2011-01-31 20:58:03 UTC
The calendar currently does not deal properly with first day of week not being a Sunday. See bug 632109 comment 57 for details.
Created attachment 179743 [details] [review] calendar: Fix event list for week starts other than Sunday In non-US locales, Monday is generally considered the first day of the week. Take this into account when building the event lists displayed under "This week"/"Next week".
Btw, there's also the question of how the grid is displayed. For example, if the week starts on a Monday, should we instead be showing M T W T F S S Jon, Jimmac?
(In reply to comment #2) > Btw, there's also the question of how the grid is displayed. For example, if > the week starts on a Monday, should we instead be showing > > M T W T F S S Yes - we already do this (assuming that with "grid" you mean the calendar itself)
(In reply to comment #3) > (In reply to comment #2) > > Btw, there's also the question of how the grid is displayed. For example, if > > the week starts on a Monday, should we instead be showing > > > > M T W T F S S > > Yes - we already do this (assuming that with "grid" you mean the calendar > itself) Oh. I think I broke this with my css-collapse hack http://people.freedesktop.org/~david/calendar-grid-non-US-locale-collapse-bug.png
(In reply to comment #1) > Created an attachment (id=179743) [details] [review] > calendar: Fix event list for week starts other than Sunday > > In non-US locales, Monday is generally considered the first day > of the week. Take this into account when building the event > lists displayed under "This week"/"Next week". Looks good to me. Committed. Thanks! (I'll keep the bug open until the issue pointed out in comment 4 is fixed. I'm working on that right now.)
Comment on attachment 179743 [details] [review] calendar: Fix event list for week starts other than Sunday Committed as d6749589e8c960266f434cb12f5709fa0fbf99ad
The grid was fixed with this commit: http://git.gnome.org/browse/gnome-shell/commit/?id=25434e42d0d933f12fcc2a6436407218e5496268 I guess we can close this bug now. Thanks.