After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 640976 - Avoid passing 'source' as an argument to Notification::destroy()
Avoid passing 'source' as an argument to Notification::destroy()
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-01-30 23:22 UTC by Marina Zhurakhinskaya
Modified: 2011-02-04 22:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Avoid passing 'source' as an argument to Notification::destroy() (1.24 KB, patch)
2011-01-30 23:22 UTC, Marina Zhurakhinskaya 		committed Details | Review

Description Marina Zhurakhinskaya 2011-01-30 23:22:26 UTC 
This was resulting in a backtrace about sending an undefined value over dbus.
Comment 1 Marina Zhurakhinskaya 2011-01-30 23:22:29 UTC 
Created attachment 179662 [details] [review]
Avoid passing 'source' as an argument to Notification::destroy()

Notification::destroy() now takes 'reason' as an optional argument.
Calling Notification::destroy() directly when connecting to 'destroy'
on Source, as we did before, was inadvertently passing 'source' as an
argument to the function.
Comment 2 Owen Taylor 2011-01-30 23:40:26 UTC 
Review of attachment 179662 [details] [review]:

Looks good to me