GNOME Bugzilla – Bug 640782
Improve application startup indicator animation
Last modified: 2011-03-15 12:37:15 UTC
There are two issues we can improve. 1. The graphic used for the animation is very poor (I know since I made it) 2. I think we can improve the animation itself We might be trying to be too clever. Perhaps should just add a spinner to the right of the application name.
TARDIS-style fade in? (Pulsing, with gradually elongating periods of opacity.)
Created attachment 183191 [details] [review] app-menu: Simplify startup animation During application startup, we used to display a rotating spinner which also moved from left to right, revealing the application title. The result looks rather busy, so remove the horizontal movement. As suggested by Jon on IRC. (In reply to comment #1) > TARDIS-style fade in? (Pulsing, with gradually elongating periods of opacity.) You should see a doctor :-)
Created attachment 183193 [details] [review] app-menu: Simplify startup animation Sorry, got it wrong for RTL locales.
Looks great! Owe you yet another one. :)
Review of attachment 183193 [details] [review]: Looks good, just some small nitpicks. ::: js/ui/panel.js @@ +339,3 @@ + Tweener.addTween(this._spinner.actor, + { opacity: 0, + time: 0.2, You didn't add it (just moved stuff around) but you could as well remove the use of a magic number here. @@ +420,2 @@ } else { + childBox.x1 = - this._spinner.actor.width; Why the whitespace?
Created attachment 183329 [details] [review] app-menu: Simplify startup animation (In reply to comment #5) > You didn't add it (just moved stuff around) but you could as well remove the > use of a magic number here. Sure. > Why the whitespace? (Obvious?) answer: it used to be a binary operation. Fixed.
Review of attachment 183329 [details] [review]: Looks good.