GNOME Bugzilla – Bug 640719
Build failure in core/display.c:process_selection_clear
Last modified: 2011-01-28 15:31:20 UTC
It seems some recent commit on master broke metacity build gcc -DHAVE_CONFIG_H -I. -I.. -I./include -DMETACITY_LIBEXECDIR=\"/opt/gnome3/libexec\" -DHOST_ALIAS=\"\" -DMETACITY_LOCALEDIR=\"/opt/gnome3/share/locale\" -DMETACITY_PKGDATADIR=\"/opt/gnome3/share/metacity\" -DMETACITY_DATADIR=\"/opt/gnome3/share\" -DG_LOG_DOMAIN=\"metacity\" -DSN_API_NOT_YET_FROZEN=1 -pthread -DORBIT2=1 -D_REENTRANT -I/opt/gnome3/include/gtk-2.0 -I/opt/gnome3/lib64/gtk-2.0/include -I/opt/gnome3/include/atk-1.0 -I/opt/gnome3/include/cairo -I/opt/gnome3/include/gdk-pixbuf-2.0 -I/opt/gnome3/include/pango-1.0 -I/opt/gnome3/include/glib-2.0 -I/opt/gnome3/lib64/glib-2.0/include -I/opt/gnome3/include/pixman-1 -I/opt/gnome3/include/gconf/2 -I/opt/gnome3/include/orbit-2.0 -I/opt/gnome3/include/startup-notification-1.0 -I/opt/gnome3/include/libgtop-2.0 -I/usr/include/freetype2 -I/usr/include/libpng12 -g -O2 -Wall -Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wcast-align -Wsign-compare -Wall -ansi -Werror -MT display.o -MD -MP -MF .deps/display.Tpo -c -o display.o `test -f 'core/display.c' || echo './'`core/display.c cc1: warnings being treated as errors core/display.c: In function ‘process_selection_clear’: core/display.c:4728: error: passing argument 1 of ‘meta_display_unmanage_screen’ from incompatible pointer type core/display-private.h:333: note: expected ‘struct MetaDisplay *’ but argument is of type ‘struct MetaDisplay **’
Checking out 25eb6ce67cbd416cd239db6c58e707e133a9a6df commit makes build works, so probably the regression was introduced by this commit http://git.gnome.org/browse/metacity/commit/?id=85aba1afe33d973bdea0229b534516c1658a44d5
Gosh, how embarrassing. Fixed. http://git.gnome.org/browse/metacity/commit/?id=9bead1ca57ba11f3fe01713f7c93959ce35d5095