After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 640639 - crash when changing the sorting order from the properties window, fully diagnosed
crash when changing the sorting order from the properties window, fully diagn...
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Preferences
2.91.x
Other All
: Normal critical
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-01-26 14:52 UTC by Stefano Teso
Modified: 2011-01-30 22:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Stefano Teso 2011-01-26 14:52:19 UTC 
There's a mismatch between:
	- NautilusIconView::sort_criteria, which exposes a subset of NautilusFileSortType, and
	- nautilus-file-management-properties[c, ui] which expose all NautilusFileSortType's (except *_NONE)

When the user changes the default sort order in the properties dialog,
	- get_sort_criterion_by_sort_type returns NULL for unimplemented sort types
	- nautilus_icon_view_real_get_directory_sort_by() returns NULL
	- nautilus_icon_view_get_directory_sort_by() returns NULL
	- the returned sort_criterion is NULL, and has no ->details->metadata_text
	- get_sort_criterion_by_metadata_text() is called with bogus pointer/data
	- segfault

This bug is very visible, hence the 'critical' status.

Obvious solutions are:
	- cut down the exposed sort types in the properties dialog
	- implement the missing NautilusFileSortTypes in nautilus-icon-view

I'm not sure on how to proceed -- i.e., I'm not sure on whether the UI has the
expected set of sort options, or the icon view code has.

Note that https://bugzilla.gnome.org/show_bug.cgi?id=627166 may have a dependency on this one.
Comment 1 André Klapper 2011-01-27 16:15:42 UTC 
(In reply to comment #0)
> This bug is very visible, hence the 'critical' status.

Any crash is critical by definition :)
Comment 2 Cosimo Cecchi 2011-01-30 22:32:49 UTC 
I just fixed this in master, thanks for the report.