After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 640637 - Camerabin has warning: Internal GStreamer error: clock problem.
Camerabin has warning: Internal GStreamer error: clock problem.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 0.10.22
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 645280 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-01-26 14:22 UTC by Luciana Fujii
Modified: 2011-05-01 12:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Handle upstream events when select-all is set (2.09 KB, patch)
2011-01-26 14:22 UTC, Luciana Fujii 		none Details | Review
Handle upstream events when select-all is set (2.33 KB, patch)
2011-02-02 23:53 UTC, Luciana Fujii 		committed Details | Review

Description Luciana Fujii 2011-01-26 14:22:03 UTC 
Created attachment 179370 [details] [review]
Handle upstream events when select-all is set

When used with clutter-gst sink or with ximagesink, camerabin posts the warning: "Internal GStreamer error: clock problem.". 

Aditional debug info: "gstbin.c(2375): gst_bin_do_latency_func (): /GstCameraBin:camerabin: Failed to configure latency of 0:00:00.000000000"

This is because input-selector doesn't handle upstream events when select-all is set. The warning doesn't occur with xvimagesink because this sink doesn't forward the latency event upstream, so it never reaches input-selector.

This patch forwards the event to all sink-pads when select-all is set. It succeeds if any of the pads does, because when select-all is set the pads that are connected to input-selector sink pads might not be active and not handle the event. This affects only the input-selector copy in camerabin.
Comment 1 Luciana Fujii 2011-02-02 23:53:57 UTC 
Created attachment 179954 [details] [review]
Handle upstream events when select-all is set

Update handling GST_ITERATOR_RESYNC and GST_ITERATOR_ERROR.
Comment 2 Thiago Sousa Santos 2011-02-08 14:33:40 UTC 
I see no harm in this as it only targets the internal camerabin input-selector. How would this work for the core input-selector?
Comment 3 Luciana Fujii 2011-02-08 15:03:27 UTC 
Since the core input-selector doesn't have a select-all property anymore, I think it doesn't have the problem I'm trying to solve here.
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2011-02-08 20:01:34 UTC 
Looks good to me. I'll push it after some testing.
Comment 5 Stefan Sauer (gstreamer, gtkdoc dev) 2011-02-09 11:45:00 UTC 
Pushed with small corrections (don't leak the element-ref, avoid cast check when unreffing the pad).

commit 2522a672a9a841a44ff4e0b20c7372092fd61010
Author: Luciana Fujii Pontello <luciana@fujii.eti.br>
Date:   Wed Jan 26 11:49:48 2011 -0200

    camerabin: Events with select-all in input-selector
    
    When select-all was set, input-selector wasn't handling upstream events.
    Now input-selector forwards the event to all of its sink pads. This
    changes the input-selector internal to camerabin until it is replaced
    with a better solution.
Comment 6 Tim-Philipp Müller 2011-04-11 15:17:45 UTC 
*** Bug 645280 has been marked as a duplicate of this bug. ***
Comment 7 Tim-Philipp Müller 2011-05-01 12:42:35 UTC 
*** Bug 649067 has been marked as a duplicate of this bug. ***