After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 640622 - gst_element_link_pads_full function return wrong error information
gst_element_link_pads_full function return wrong error information
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.10.32
Other Linux
: Normal normal
: 0.10.33
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-01-26 09:17 UTC by chen rui
Modified: 2011-02-14 20:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix this bug (1.26 KB, patch)
2011-01-26 09:22 UTC, chen rui 		committed Details | Review

Description chen rui 2011-01-26 09:17:27 UTC 
I use gst-launch-0.10 alsasrc ! ximagesink to test function gst_element_link_pads_full. 

When loop through the pads in the source, it can't find a compatible destination pad, then it will loop through the pads in the destination, it also can't find a compatible source pad, but it will return wrong error information(sink is not 
source pad, failed) during call gst_element_get_compatible_pad().

This error is caused by using wrong order of pad when call gst_pad_check_link().
Comment 1 chen rui 2011-01-26 09:22:21 UTC 
Created attachment 179359 [details] [review]
fix this bug

This is my patch
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2011-02-14 20:45:46 UTC 
Comment on attachment 179359 [details] [review]
fix this bug

Thanks for the patch.

commit b164a8232a0c3f27b9904912f7fff39a26bedadd
Author: Chen Rui <rui.chen@tieto.com>
Date:   Wed Jan 26 16:46:25 2011 +0800

    utils: return real error in compatible link check
    
    We need to ensure we call gst_pad_check_link() with the two pads in the correct
    order. The order depends on wheter we iterate src or sink pads.
    
    Signed-off-by: Chen Rui <rui.chen@tieto.com>