After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 640612 - Sample Colorize does not function non-interactively
Sample Colorize does not function non-interactively
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Plugins
2.6.11
Other All
: Normal normal
: 2.6
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2011-01-26 03:47 UTC by saulgoode
Modified: 2011-02-14 17:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Attempt to fix bug. (1.13 KB, application/octet-stream)
2011-01-26 03:47 UTC, saulgoode
Details

Description saulgoode 2011-01-26 03:47:31 UTC
Created attachment 179349 [details]
Attempt to fix bug.

The Sample Colorize plug-in does not function properly when invoked non-interactively. Instead of performing the operation using the passed parameters, the plug-in exits without doing anything (and without generating any warnings or errors).

Attached is a patch which attempts to rectify this. 

Note: the Sample Colorize plug-in's interface is pretty non-standard relative to the approach taken by most other plug-ins. This patch makes no attempt to address this. Nor does the patch attempt to address that the plug-in does not support run-with-last-values mode.
Comment 1 Michael Natterer 2011-02-14 11:03:33 UTC
Very nice. I take it the patch was tested? (because I have no clue
whatsoever how to use this plugin noninteractively).
Comment 2 saulgoode 2011-02-14 16:27:25 UTC
In addition to my own testing of the patch, the user on the gimp-user mailing list[1] who initially raised the issue has also had success with it. 



[1] http://www.mail-archive.com/gimp-user%40lists.xcf.berkeley.edu/msg20721.html
Comment 3 Michael Natterer 2011-02-14 17:57:18 UTC
Thanks, fixed in master and 2.6:

commit 762c707b838a9c766aa0f4b151c4d164da95c92b
Author: Saul Goode <saulgoode@flashingtwelve.brickfilms.com>
Date:   Tue Jan 25 22:26:36 2011 -0500

    Bug 640612 - Sample Colorize does not function non-interactively
    
    Fixed bug with Sample Colorize plugin's non-interactive mode
    (cherry picked from commit 2d419a0cb1e4135caddf7f2a1795947db39bcda5)

 plug-ins/common/sample-colorize.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)