GNOME Bugzilla – Bug 640561
opencv textwrite element renaming and proper structuring:
Last modified: 2011-03-28 17:31:22 UTC
Created attachment 179304 [details] [review] patch for renaming and structuring opencv textwrite element. Opencv textwrite element is only a sample implementation for text overlay with opencv. I think It is better to rename the element name to "opecvtextoverlay". Also adding more structuring and gstreamer coding conventions to the implementation.
Created attachment 179330 [details] [review] patch for changing doc and element details
I think it is worth changing for consistency with other elements. Anyone has a reason against this?
+1
Any update?
(In reply to comment #4) > Any update? The patches don't apply right now for me. Could you please squash the changes in one patch (in this case) and update it. I'll apply it right away then.
(In reply to comment #5) > (In reply to comment #4) > > Any update? > > The patches don't apply right now for me. Could you please squash the changes > in one patch (in this case) and update it. I'll apply it right away then. You mean, merging the two patches to a single one?
(In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > Any update? > > > > The patches don't apply right now for me. Could you please squash the changes > > in one patch (in this case) and update it. I'll apply it right away then. > > You mean, merging the two patches to a single one? Yes, the 2nd patch basically does s/opencvopencv/opencv/ for strings introduced in the first patch. Please also take care of "FIXME:Describe opencvtextoverlay here." - just add one or two sentences about what the element does. Regarding the example pipeline, this should be a meaningful one (e.g. one where you can see something).
Created attachment 184391 [details] [review] Added proper structuring to opencv textoverlay element.
I hope the new patch is fine. Anyway we need some clean-ups in most of the opencv elements(at least some comment change).
Review of attachment 184391 [details] [review]: Looks good and applies fine this time. Will push after a round of testing. Simillar fixes to the other opencv elements are appreciated :)
Comment on attachment 184391 [details] [review] Added proper structuring to opencv textoverlay element. committed with additional changes. commit d6a1eebf37dbec4ecfcf4b869e716223a5a0137e Author: Sreerenj Balachandran <sreerenj.balachandran@nokia.com> Date: Sun Mar 27 23:50:24 2011 +0300 opencv text overlay: rename and docuemnt Rename the element textwrite to opencvtextoverlay. Add proper structuring to opencv textoverlay element. Fixes: #640561