After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 640561 - opencv textwrite element renaming and proper structuring:
opencv textwrite element renaming and proper structuring:
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.22
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-01-25 17:49 UTC by sreerenj
Modified: 2011-03-28 17:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch for renaming and structuring opencv textwrite element. (36.60 KB, patch)
2011-01-25 17:49 UTC, sreerenj
none Details | Review
patch for changing doc and element details (1.57 KB, patch)
2011-01-25 21:39 UTC, sreerenj
none Details | Review
Added proper structuring to opencv textoverlay element. (36.67 KB, patch)
2011-03-27 21:04 UTC, sreerenj
committed Details | Review

Description sreerenj 2011-01-25 17:49:58 UTC
Created attachment 179304 [details] [review]
patch for renaming and structuring opencv textwrite element.

Opencv textwrite element is only a  sample implementation for text overlay with opencv.
I think It is better to rename  the element name to "opecvtextoverlay". Also adding more structuring and  gstreamer coding conventions to the implementation.
Comment 1 sreerenj 2011-01-25 21:39:20 UTC
Created attachment 179330 [details] [review]
patch for changing doc and element details
Comment 2 Thiago Sousa Santos 2011-01-28 13:09:28 UTC
I think it is worth changing for consistency with other elements. Anyone has a reason against this?
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2011-01-29 20:53:30 UTC
+1
Comment 4 sreerenj 2011-03-26 09:34:32 UTC
Any update?
Comment 5 Stefan Sauer (gstreamer, gtkdoc dev) 2011-03-27 18:57:09 UTC
(In reply to comment #4)
> Any update?

The patches don't apply right now for me. Could you please squash the changes in one patch (in this case) and update it. I'll apply it right away then.
Comment 6 sreerenj 2011-03-27 19:06:49 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > Any update?
> 
> The patches don't apply right now for me. Could you please squash the changes
> in one patch (in this case) and update it. I'll apply it right away then.

You mean, merging the two patches to a single one?
Comment 7 Stefan Sauer (gstreamer, gtkdoc dev) 2011-03-27 19:23:23 UTC
(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > Any update?
> > 
> > The patches don't apply right now for me. Could you please squash the changes
> > in one patch (in this case) and update it. I'll apply it right away then.
> 
> You mean, merging the two patches to a single one?

Yes, the 2nd patch basically does s/opencvopencv/opencv/ for strings introduced in the first patch.

Please also take care of "FIXME:Describe opencvtextoverlay here." - just add one or two sentences about what the element does. Regarding the example pipeline, this should be a meaningful one (e.g. one where you can see something).
Comment 8 sreerenj 2011-03-27 21:04:51 UTC
Created attachment 184391 [details] [review]
Added proper structuring to opencv textoverlay element.
Comment 9 sreerenj 2011-03-27 21:06:39 UTC
I hope the new patch is fine. Anyway we need some clean-ups in most of the opencv elements(at least some comment change).
Comment 10 Stefan Sauer (gstreamer, gtkdoc dev) 2011-03-28 06:56:11 UTC
Review of attachment 184391 [details] [review]:

Looks good and applies fine this time. Will push after a round of testing. Simillar fixes to the other opencv elements are appreciated :)
Comment 11 Stefan Sauer (gstreamer, gtkdoc dev) 2011-03-28 17:31:22 UTC
Comment on attachment 184391 [details] [review]
Added proper structuring to opencv textoverlay element.

committed with additional changes.

commit d6a1eebf37dbec4ecfcf4b869e716223a5a0137e
Author: Sreerenj Balachandran <sreerenj.balachandran@nokia.com>
Date:   Sun Mar 27 23:50:24 2011 +0300

    opencv text overlay: rename and docuemnt
    
    Rename the element textwrite to opencvtextoverlay. Add proper structuring to
    opencv textoverlay element.
    
    Fixes: #640561