After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 640556 - gcc 4.6 complains about soup-cache.c
gcc 4.6 complains about soup-cache.c
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: Misc
2.31.x
Other Linux
: Normal normal
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2011-01-25 17:23 UTC by Dan Winship
Modified: 2011-01-31 21:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
soup-cache: fix a warning (and a bug) (1.47 KB, patch)
2011-01-25 17:24 UTC, Dan Winship 		committed Details | Review

Description Dan Winship 2011-01-25 17:23:19 UTC 
"must_revalidate" in soup_cache_has_response() is set, but never used. I think the attached patch is correct... (setting a cache-control flag on a request shouldn't permanently change the attributes of the cached response, right?)
Comment 1 Dan Winship 2011-01-25 17:24:39 UTC 
Created attachment 179300 [details] [review]
soup-cache: fix a warning (and a bug)

If a request specifies "Cache-Control: max-age=0", revalidate the
response, but don't mark the cache entry as "must_revalidate", since
the need for revalidation applies only to the current request.
Comment 2 Sergio Villar 2011-01-25 17:49:44 UTC 
(In reply to comment #0)
> "must_revalidate" in soup_cache_has_response() is set, but never used. I think
> the attached patch is correct... (setting a cache-control flag on a request
> shouldn't permanently change the attributes of the cached response, right?)

Yeah, I think you're right, makes no sense to force revalidation forever.
Comment 3 Dan Winship 2011-01-31 21:35:18 UTC 
Attachment 179300 [details] pushed as d9bf1c0 - soup-cache: fix a warning (and a bug)