GNOME Bugzilla – Bug 640510
Updated MSVC Project File Set (VS2010 support and automation added)
Last modified: 2012-03-13 22:08:41 UTC
Created attachment 179269 [details] [review] Updates to the Visual C++ 2008 Project Files Hi, I have managed to update the Visual C++ 2008 Project Files that was committed to master some time ago. This will make the versioning data in config.h.win32 be done automatically during "make dist", plus it will simplify maintenance of the Project Files by removing unneeded stuff from them and making the source files of the JSON-GLib library be added to the json-glib.vcproj file also during "make dist". The Makefile.am's in json-glib/, build/win32, build/win32/vs9 and configure.ac has been updated to make the above changes possible. A seperate json-version.h.win32 is no longer needed, and b/build/win32/config.h.win32 has been adapted into b/build/win32/config.h.win32.in also due to the changes above. I have updated the .sln and .vcproj(in) files too to include configurations for x64-builds, but please note I did not test these configurations as I run Visual C++ 2008 Express (which is quite hard to get an x64 compiler to work with the IDE). I will split the patch in 2 parts-one for the Project Files stuff, which is with this main bug report, and another for the changes to the configure.ac, Makefile.am's and the changes to build/win32/json-version.h.win32 (removal) and build/win32/json-version.h.win32(.in) (adaptation to automated versioning for make dist) in a comment that I will post shortly.
Created attachment 179270 [details] [review] Changes to autotools files and generated headers Hi, This is the patch to update configure.ac and the Makefile.am's, along with the changes to build/win32/json-version.h.win32 and build/win32/config.h.win32 (remove) and the addition of build/win32/config.h.win32.in Thanks
Created attachment 185804 [details] [review] MSVC 2008/2010 support with automation Hi, (Sorry for the sheer size of the patch as I am pretty new to using git format-patch :) ) This supercedes the patches I had in this bug report, as this patch set has been enhanced with VS2010 support and cleanups in the VS2008 project files, in addition to adding automation (to both the VS2008 and VS2010 projects). This was patched against the master branch, and I have verified it by building with VS2008 and VS2010, and also distchecked it successfully on my Ubuntu 10.10 system. Thanks for your time.
I have created a msvc-patch branch in JSON-GLib[1] with the updates from "comment 2", as I read from Clutter's README.md file. Hope this helps on the eyes. Thank you! [1]: The links to the commits in the msvc-patch branch are: Update VS 2008 Project Files--http://git.gnome.org/browse/json-glib/commit/?h=msvc-patch&id=20fe28cfaa605e11c47fe53232b5dccfa47ddf8b MSVC Support with automation added (autotools part)--http://git.gnome.org/browse/json-glib/commit/?h=msvc-patch&id=a7bdf87ec150ac7a88a850190fa79359197e552e Updates to MSVC pre-configured headers--http://git.gnome.org/browse/json-glib/commit/?h=msvc-patch&id=6c74292e66be25840612d7ee6871f1668010eada VS 2010 Project Files (automation support included)--http://git.gnome.org/browse/json-glib/commit/?h=msvc-patch&id=46a8e576f2fae9563219fcd72a9866826e684559
pinging this...! Sorry for bugging. Thank you!
Merged the changes into master after confirmation with ebassi. Thank you! :)
[Fixing Default QA assignee for json-glib - see 613232#c1. Sorry for bugmail noise.]