After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 640493 - Cancel button in search entry stopped working
Cancel button in search entry stopped working
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-01-25 00:28 UTC by Florian Müllner
Modified: 2011-01-25 09:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
swipe-scroll: Don't eat button-release events on click (2.39 KB, patch)
2011-01-25 00:28 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2011-01-25 00:28:19 UTC
This is a fallout from the new swipe-scrolling code, see attached patch.
Comment 1 Florian Müllner 2011-01-25 00:28:22 UTC
Created attachment 179257 [details] [review]
swipe-scroll: Don't eat button-release events on click

The main overview group starts capturing events on button-press
events to implement swipe-scrolling. While reactive children of
the group which handle both button-press and button-release events
don't trigger swipe-scrolling, children that only rely on
button-release have stopped working - at least the primary/secondary
icons of the search entry are affected. While the capture handler
already checks the pointer movement between press and release to
determine whether the action should be considered a click rather
than a drag, it still blocks the release event from propagating.
Instead, only block release events for drag actions, but not for
clicks.
Comment 2 Owen Taylor 2011-01-25 02:52:46 UTC
Review of attachment 179257 [details] [review]:

Seems fine
Comment 3 Florian Müllner 2011-01-25 09:32:11 UTC
Attachment 179257 [details] pushed as b9e1d91 - swipe-scroll: Don't eat button-release events on click