After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 640464 - Unselect the Wikipedia button if there is another search result
Unselect the Wikipedia button if there is another search result
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-01-24 20:12 UTC by Marina Zhurakhinskaya
Modified: 2011-01-26 01:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Unselect search button if there is search result (840 bytes, patch)
2011-01-24 23:40 UTC, Maxim Ermilov
committed Details | Review

Description Marina Zhurakhinskaya 2011-01-24 20:12:08 UTC
The new Wikipedia button doesn't get unselected if I update my search string so that there is a local result. This can happen if I originally mistyped the name of an application. It's easy to overlook that the Wikipedia button is selected and just hit enter intending to launch the application, but instead get the web page.

The selection goes back to the first result in the top section when results are updated in other sections.

E.g
1. Typing "app" gets the first application result selected
2. Updating the string to "appe" gets no application results, but gets Appearance Preferences selected under Preferences
3. Updating the string back to "app" gets the first application result selected again
4. Updating the string to "appeal" shows no local results and selects the Wikipedia button
5. Updating the string to "appea" shows Appearance Preferences result under Preferences, but keeps the Wikipedia button selected (wrong behavior)
Comment 1 Maxim Ermilov 2011-01-24 23:40:21 UTC
Created attachment 179254 [details] [review]
Unselect search button if there is search result
Comment 2 Marina Zhurakhinskaya 2011-01-25 23:20:54 UTC
Review of attachment 179254 [details] [review]:

Looks good and works as expected.