After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 640417 - EmpathyAccountWidget should be a proper GtkWidget
EmpathyAccountWidget should be a proper GtkWidget
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Accounts
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2011-01-24 13:49 UTC by Guillaume Desmottes
Modified: 2012-05-08 07:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Turn EmpathyAccountWidget to a proper GtkWidget (32.51 KB, patch)
2012-05-04 13:36 UTC, Guillaume Desmottes
committed Details | Review

Description Guillaume Desmottes 2011-01-24 13:49:26 UTC
EmpathyAccountWidget is currently a GObject and not a proper GtkWidget. This leads it to do some nasty things such as unrefing itself when the widget is destroyed (account_widget_destroy_cb).
We should refactor this at some point to make it saner.
Comment 1 Guillaume Desmottes 2012-05-04 13:36:05 UTC
Created attachment 213440 [details] [review]
Turn EmpathyAccountWidget to a proper GtkWidget
Comment 2 Xavier Claessens 2012-05-08 07:09:45 UTC
Since you pack only one child, it could be GtkBin instead of GtkBox. IIRC GtkBin is useful since GTK3, you don't have to reimplement size request/allocate anymore.
Comment 3 Xavier Claessens 2012-05-08 07:10:08 UTC
The rest looks good.
Comment 4 Guillaume Desmottes 2012-05-08 07:17:33 UTC
Attachment 213440 [details] pushed as d86e51d - Turn EmpathyAccountWidget to a proper GtkWidget