GNOME Bugzilla – Bug 640417
EmpathyAccountWidget should be a proper GtkWidget
Last modified: 2012-05-08 07:17:35 UTC
EmpathyAccountWidget is currently a GObject and not a proper GtkWidget. This leads it to do some nasty things such as unrefing itself when the widget is destroyed (account_widget_destroy_cb). We should refactor this at some point to make it saner.
Created attachment 213440 [details] [review] Turn EmpathyAccountWidget to a proper GtkWidget
Since you pack only one child, it could be GtkBin instead of GtkBox. IIRC GtkBin is useful since GTK3, you don't have to reimplement size request/allocate anymore.
The rest looks good.
Attachment 213440 [details] pushed as d86e51d - Turn EmpathyAccountWidget to a proper GtkWidget