GNOME Bugzilla – Bug 640410
codegen: Respect ignore-type for miniobjects
Last modified: 2011-02-09 11:55:04 UTC
gst-python 0.10.21 dies with gst-plugins-base older than 0.10.32 because miniobject types are not completely ignored as they should be. I get an error like: GEN pbutils.c ***INFO*** The coverage of global functions is 100.00% (24/24) ***INFO*** The coverage of methods is 100.00% (1/1) ***INFO*** There are no declared virtual proxies. ***INFO*** There are no declared virtual accessors. ***INFO*** There are no declared interface proxies. CC pbutils_la-pbutils.lo pbutils.c: In function 'pypbutils_register_classes': pbutils.c:983:60: error: 'GST_TYPE_DISCOVERER_INFO' undeclared (first use in this function) pbutils.c:983:60: note: each undeclared identifier is reported only once for each function it appears in pbutils.c:984:66: error: 'GST_TYPE_DISCOVERER_STREAM_INFO' undeclared (first use in this function) pbutils.c:985:69: error: 'GST_TYPE_DISCOVERER_CONTAINER_INFO' undeclared (first use in this function) pbutils.c:986:65: error: 'GST_TYPE_DISCOVERER_AUDIO_INFO' undeclared (first use in this function) pbutils.c:987:65: error: 'GST_TYPE_DISCOVERER_VIDEO_INFO' undeclared (first use in this function) pbutils.c:988:61: error: 'GST_TYPE_ENCODING_PROFILE' undeclared (first use in this function) pbutils.c:989:70: error: 'GST_TYPE_ENCODING_CONTAINER_PROFILE' undeclared (first use in this function) pbutils.c:990:66: error: 'GST_TYPE_ENCODING_VIDEO_PROFILE' undeclared (first use in this function) pbutils.c:991:66: error: 'GST_TYPE_ENCODING_AUDIO_PROFILE' undeclared (first use in this function) pbutils.c:992:60: error: 'GST_TYPE_ENCODING_TARGET' undeclared (first use in this function) make[3]: *** [pbutils_la-pbutils.lo] Error 1 make[3]: Leaving directory `/home/arun/work/gnome2/gst-python/gst' make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory `/home/arun/work/gnome2/gst-python/gst' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/arun/work/gnome2/gst-python' make: *** [all] Error 2 Attaching a fix for this.
Created attachment 179156 [details] [review] codegen: Respect ignore-type for miniobjects
Review of attachment 179156 [details] [review]: works for me
commit c95985640f68f46235a5829227684a6aa3f9d615 Author: Arun Raghavan <arun.raghavan@collabora.co.uk> Date: Mon Jan 24 17:55:55 2011 +0530 codegen: Respect ignore-type for miniobjects https://bugzilla.gnome.org/show_bug.cgi?id=640410 commit 93fd2d4f43ced070fbb1b8a0e4d33d23601957d5 Author: Arun Raghavan <arun.raghavan@collabora.co.uk> Date: Mon Jan 24 17:56:16 2011 +0530 codegen: Handle empty lines in overrides gracefully Without this, having an empty line in an override will cause codegen to unceremoniously choke to death. https://bugzilla.gnome.org/show_bug.cgi?id=640341