After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 640399 - [PATCH] Fix iagno background grid.
[PATCH] Fix iagno background grid.
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: iagno
trunk
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2011-01-24 11:30 UTC by Rufus Hamade
Modified: 2011-02-08 00:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix adding back background grid. (9.75 KB, patch)
2011-01-24 11:56 UTC, Rufus Hamade
none Details | Review
Better patch with crisper lines (9.75 KB, patch)
2011-01-24 12:15 UTC, Rufus Hamade
none Details | Review
Better patch without background color hack. (11.28 KB, patch)
2011-02-07 14:47 UTC, Rufus Hamade
committed Details | Review

Description Rufus Hamade 2011-01-24 11:30:15 UTC
Iagno background grid was "broken" by commit 
http://git.gnome.org/browse/gnome-games/commit/?id=764c51939d8eb7eb647b76bbd9d28d2adc3a0726
that cairo-ised it.  This fix fixes things up again.
Comment 1 Rufus Hamade 2011-01-24 11:56:52 UTC
Created attachment 179150 [details] [review]
Fix adding back background grid.
Comment 2 Rufus Hamade 2011-01-24 12:15:26 UTC
Created attachment 179151 [details] [review]
Better patch with crisper lines

I compared the latest iagno with the Ubuntu-shipped version and noticed how fuzzy the grid lines were.  This patch fixes things up.
Comment 3 Rufus Hamade 2011-02-07 14:47:49 UTC
Created attachment 180302 [details] [review]
Better patch without background color hack.

Patch does background and grid color without resorting to extracting color from the pixmap.  

The background is filled using 1x1 pixel surface created from the tile pixmap.

The grid is drawn using the "DIFFERENCE" compositing operator, and drawing in white.  The resulting color is then the difference between white and the background color - which is what we did before.

I think there is nothing else I can do to improve this patch.  HTH.
Comment 4 Thomas Andersen 2011-02-08 00:20:34 UTC
Comment on attachment 180302 [details] [review]
Better patch without background color hack.

Committed to master with some trailing whitespace fixes.

http://git.gnome.org/browse/gnome-games/commit/?id=8348bce106c9894171ec1a3cfbb04c2db94b0b84
Comment 5 Thomas Andersen 2011-02-08 00:21:16 UTC
Thanks Rufus. Nice patch