GNOME Bugzilla – Bug 640399
[PATCH] Fix iagno background grid.
Last modified: 2011-02-08 00:21:16 UTC
Iagno background grid was "broken" by commit http://git.gnome.org/browse/gnome-games/commit/?id=764c51939d8eb7eb647b76bbd9d28d2adc3a0726 that cairo-ised it. This fix fixes things up again.
Created attachment 179150 [details] [review] Fix adding back background grid.
Created attachment 179151 [details] [review] Better patch with crisper lines I compared the latest iagno with the Ubuntu-shipped version and noticed how fuzzy the grid lines were. This patch fixes things up.
Created attachment 180302 [details] [review] Better patch without background color hack. Patch does background and grid color without resorting to extracting color from the pixmap. The background is filled using 1x1 pixel surface created from the tile pixmap. The grid is drawn using the "DIFFERENCE" compositing operator, and drawing in white. The resulting color is then the difference between white and the background color - which is what we did before. I think there is nothing else I can do to improve this patch. HTH.
Comment on attachment 180302 [details] [review] Better patch without background color hack. Committed to master with some trailing whitespace fixes. http://git.gnome.org/browse/gnome-games/commit/?id=8348bce106c9894171ec1a3cfbb04c2db94b0b84
Thanks Rufus. Nice patch