After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 640284 - Fails to build when libsocialweb-client is not installed
Fails to build when libsocialweb-client is not installed
Status: RESOLVED FIXED
Product: nautilus-sendto
Classification: Applications
Component: general
2.90.x
Other Linux
: Normal normal
: ---
Assigned To: nautilus-sendto-maint
nautilus-sendto-maint
Depends on:
Blocks:
 
 
Reported: 2011-01-22 18:40 UTC by Emilio Pozuelo Monfort
Modified: 2011-02-02 13:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Dont hardcode the list of plugins to build (1.74 KB, patch)
2011-01-22 18:41 UTC, Emilio Pozuelo Monfort 		committed Details | Review

Description Emilio Pozuelo Monfort 2011-01-22 18:40:24 UTC 
The socialweb plugin is optional, so when libsocialweb-client is not found, it is disabled.

However, src/plugins/Makefile.am hardcodes it, so it gets built, no matter what.

My patch disables in configure.in the unported plugins to the new API, so only those that have all the deps and are requested, among those that have been ported, are built.
Comment 1 Emilio Pozuelo Monfort 2011-01-22 18:41:53 UTC 
Created attachment 179052 [details] [review]
Dont hardcode the list of plugins to build
Comment 2 Bastien Nocera 2011-02-02 13:27:42 UTC 
I removed the libsocialweb version downgrade though, as the upgrade is necessary for the video upload support.