After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 640249 - [taginject] Taginject does not allow to change tags after init
[taginject] Taginject does not allow to change tags after init
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other Linux
: Normal normal
: 0.10.29
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-01-22 11:29 UTC by Tuukka Pasanen
Modified: 2011-03-08 15:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fixing taginject-element so it sends tags allways when tags are edited (137.05 KB, patch)
2011-01-22 11:29 UTC, Tuukka Pasanen 		none Details | Review
This correct patch to make taginject to work as stuff changes send it forward (614 bytes, patch)
2011-02-14 12:24 UTC, Tuukka Pasanen 		committed Details | Review

Description Tuukka Pasanen 2011-01-22 11:29:10 UTC 
Created attachment 179028 [details] [review]
Fixing taginject-element so it sends tags allways when tags are edited

Taginject refuses to change tags after it is inited. It makes problem if you want to use example shout2send and taginject as metadata provider (There is other cases also). Patch fixes the problem.
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2011-02-14 11:29:41 UTC 
Could you please redo the patch (git style), it contains a lot of unrelated changes.
Comment 2 Tuukka Pasanen 2011-02-14 12:24:36 UTC 
Created attachment 180818 [details] [review]
This correct patch to make taginject to work as stuff changes send it forward
Comment 3 Tuukka Pasanen 2011-02-14 12:26:03 UTC 
My bad! Wrong patch but this is correct one. It's very very simple as you can see.
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2011-02-14 13:26:04 UTC 
Indeed! Thanks and pushed.

commit d203b1ef5040a180891f0ca5ee00c57d33865300
Author: Tuukka Pasanen <tuukka.pasanen@ilmi.fi>
Date:   Mon Feb 14 15:21:29 2011 +0200

    taginject: resend tags when they are changed
    
    Allow setting new tags on the property while running and send them.
    
    Fixes #640249