Bug 640240 - [gnome-terminal] When using theme colors, white-on-white text
[gnome-terminal] When using theme colors, white-on-white text
Status: RESOLVED INCOMPLETE
Product: gtk+
Classification: Platform
Component: Class: GtkStyleContext
2.99.x
Other Linux
: Normal normal
: ---
Assigned To: Carlos Garnacho
gtk-bugs
[gnome3-important]
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2011-01-22 04:51 UTC by Matthias Clasen
Modified: 2012-01-20 17:10 UTC (History)
4 users (show)

See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Matthias Clasen 2011-01-22 04:51:49 UTC 
This is probably some regression in GtkStyle, and will be fixed by porting gnome-terminal to GtkStyleContext.
Comment 1 Christian Persch 2011-02-02 20:33:53 UTC 
Actually it's black-on-black here. The code is using these colours:

  fg = style->text[GTK_STATE_NORMAL];
  bg = style->base[GTK_STATE_NORMAL];

Were the meaning of text/base changed in gtk3 ?
Comment 2 Christian Persch 2011-02-03 22:40:44 UTC 
There's a few style-updated signals coming, and the last one has fg=bg=0,0,0.

+ Trace 225835

  • #0 terminal_screen_style_updated
    at ../../../src/terminal-screen.c line 308
  • #1 g_cclosure_marshal_VOID__VOID
    at gmarshal.c line 79
  • #2 g_type_class_meta_marshal
    at gclosure.c line 878
  • #3 g_closure_invoke
    at gclosure.c line 767
  • #4 signal_emit_unlocked_R
    at gsignal.c line 3182
  • #5 g_signal_emit_valist
    at gsignal.c line 2983
  • #6 g_signal_emit
    at gsignal.c line 3040
  • #7 style_context_changed
    at gtkwidget.c line 14145
  • #8 g_cclosure_marshal_VOID__VOID
    at gmarshal.c line 79
  • #9 g_closure_invoke
    at gclosure.c line 767
  • #10 signal_emit_unlocked_R
    at gsignal.c line 3252
  • #11 g_signal_emit_valist
    at gsignal.c line 2983
  • #12 g_signal_emit
    at gsignal.c line 3040
  • #13 gtk_style_context_invalidate
    at gtkstylecontext.c line 3278
  • #14 modifier_style_changed
    at gtkwidget.c line 8032
  • #15 g_cclosure_marshal_VOID__VOID
    at gmarshal.c line 79
  • #16 g_closure_invoke
    at gclosure.c line 767
  • #17 signal_emit_unlocked_R
    at gsignal.c line 3252
  • #18 g_signal_emit_valist
    at gsignal.c line 2983
  • #19 g_signal_emit
    at gsignal.c line 3040
  • #20 modifier_style_set_color
    at gtkmodifierstyle.c line 183
  • #21 gtk_modifier_style_set_background_color
    at gtkmodifierstyle.c line 194
  • #22 gtk_widget_override_background_color
    at gtkwidget.c line 8136
  • #23 gtk_widget_modify_bg
    at gtkwidget.c line 8352
  • #24 vte_terminal_background_update
    at ../../../src/vte.c line 13203
  • #25 vte_terminal_realize
    at ../../../src/vte.c line 9158
  • #26 terminal_screen_realize
    at ../../../src/terminal-screen.c line 294 

So it seems to happen due to the vte background code. Color is 0,0,0 in #23. Still, this works in gtk2, so this has to be a gtk bug with the new style code interfering with the old style code...
Comment 3 Matthias Clasen 2011-03-03 20:11:55 UTC 
I don't know how to reproduce this
Comment 4 Christian Persch 2011-03-03 20:18:34 UTC 
(In reply to comment #3)
> I don't know how to reproduce this

I think checking "Use theme colours" in the profile preferences is what you did originally ?
Comment 5 André Klapper 2011-03-03 21:16:27 UTC 
[Removing GNOME3.0 target as decided in release-team meeting on March 03, 2011.
This report has an "important" categorisation for GNOME3.0 but is not considered a hard blocker. For querying use the corresponding whiteboard entry added.]
Comment 6 Matthias Clasen 2011-03-18 01:13:59 UTC 
(In reply to comment #4)
> (In reply to comment #3)
> > I don't know how to reproduce this
> 
> I think checking "Use theme colours" in the profile preferences is what you did
> originally ?

Yeah, but that does not reproduce any kind of white-on-white or black-on-black or other color problem here.
Comment 7 Tobias Mueller 2011-07-01 09:26:11 UTC 
Christian, do you have any more hints as to how to reproduce this issue?
Comment 8 Tobias Mueller 2012-01-20 17:10:28 UTC 
Closing this bug report as no further information has been provided. Please feel free to reopen this bug if you can provide the information asked for.
Thanks!
Note You need to log in before you can comment on or make changes to this bug.