After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 640213 - Add tests for LinkedHashSet
Add tests for LinkedHashSet
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: libfolks
git master
Other Linux
: Normal normal
: Unset
Assigned To: folks-maint
folks-maint
Depends on:
Blocks: 640092
 
 
Reported: 2011-01-21 19:13 UTC by Travis Reitter
Modified: 2011-01-24 23:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Basic tests for LinkedHashSet (8.33 KB, patch)
2011-01-21 19:19 UTC, Travis Reitter 		none Details | Review
Basic tests for LinkedHashSet (8.55 KB, patch)
2011-01-21 22:02 UTC, Travis Reitter 		accepted-commit_now Details | Review

Description Travis Reitter 2011-01-21 19:13:47 UTC 
Since we're planning to use LinkedHashSet quite a bit, we should probably add some tests for it.
Comment 1 Travis Reitter 2011-01-21 19:19:55 UTC 
Created attachment 178993 [details] [review]
Basic tests for LinkedHashSet

Squashed diff of branch:

http://git.collabora.co.uk/?p=user/treitter/folks.git;a=shortlog;h=refs/heads/bgo640213-hash-set-tests

===========

These tests aren't exhaustive, but they should cover some of the main uses. We can add new tests as necessary.
Comment 2 Travis Reitter 2011-01-21 22:02:51 UTC 
Created attachment 179009 [details] [review]
Basic tests for LinkedHashSet

Squashed diff of branch:

http://git.collabora.co.uk/?p=user/treitter/folks.git;a=shortlog;h=refs/heads/bgo640213-hash-set-tests-2

================

This includes the new test's .stamp file in MAINTAINERCLEANFILES
Comment 3 Philip Withnall 2011-01-22 00:01:38 UTC 
Review of attachment 179009 [details] [review]:

Looks good to me.
Comment 4 Travis Reitter 2011-01-24 23:56:26 UTC 
commit 797b08434b1d3429cf66eced1dcd8c7d90304e90
Author: Travis Reitter <travis.reitter@collabora.co.uk>
Date:   Fri Jan 21 11:08:44 2011 -0800

    Add some LinkedHashSet tests.
    
    Fixes bgo#640213 -- Add tests for LinkedHashSet

 NEWS                             |    1 +
 tests/folks/Makefile.am          |    6 +
 tests/folks/linked-hash-set.vala |  254 ++++++++++++++++++++++++++++++++++++++
 3 files changed, 261 insertions(+), 0 deletions(-)