After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 640085 - Look of search entry after using it
Look of search entry after using it
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
2.91.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-01-20 17:30 UTC by Michael Monreal
Modified: 2011-01-20 22:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot (14.85 KB, image/png)
2011-01-20 17:30 UTC, Michael Monreal
  Details
st: Report correct paint volumes during transitions (4.71 KB, patch)
2011-01-20 21:09 UTC, Florian Müllner
committed Details | Review

Description Michael Monreal 2011-01-20 17:30:28 UTC
Created attachment 178857 [details]
Screenshot

Go to overview,
- type something in the search entry and press (x)
or
- just click into the search entry and then click outside

=> the corners of the entry widget look broken (on g-s git master as of today on f14 with intel hardware)
Comment 1 Florian Müllner 2011-01-20 21:09:12 UTC
Created attachment 178886 [details] [review]
st: Report correct paint volumes during transitions

StWidget reports a paint volume large enough to paint the current
theme node. As CSS transitions also paint the previous theme node,
the reported paint volume may be incorrect, resulting in screen
artifacts when painting outside the reported volume.

Add st_theme_node_transition_get_paint_box() to calculate an allocation
large enough to paint both theme nodes, and use it to report the correct
paint volume during transitions.
Comment 2 Owen Taylor 2011-01-20 21:29:20 UTC
Review of attachment 178886 [details] [review]:

Looks good

::: src/st/st-widget.c
@@ +694,3 @@
     return FALSE;
 
+  priv = ST_WIDGET(self)->priv;

missing space
Comment 3 Florian Müllner 2011-01-20 22:25:17 UTC
Attachment 178886 [details] pushed as 289d577 - st: Report correct paint volumes during transitions