After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 640010 - don't show icons for non-apps in removable media dropdowns
don't show icons for non-apps in removable media dropdowns
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Removable Media
git master
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-01-19 23:03 UTC by William Jon McCann
Modified: 2011-01-20 20:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtk patch (1.37 KB, patch)
2011-01-20 01:03 UTC, William Jon McCann 		committed Details | Review

Description William Jon McCann 2011-01-19 23:03:07 UTC 
We shouldn't show icons for:
 * Other application
 * Ask what to do
 * Do nothing
 * Open folder

They are not noun objects and we shouldn't show icons for them.
Comment 1 William Jon McCann 2011-01-20 01:03:56 UTC 
Created attachment 178802 [details] [review]
gtk patch

It is slightly unfortunate that combobox uses a separate column for the icon instead of packing it into the label column.  This means that the column alignment differs in adjacent comboboxes.
Comment 2 William Jon McCann 2011-01-20 20:57:52 UTC 
Should be all fixed now.