After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 639987 - Strings requiring plural forms
Strings requiring plural forms
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 642839 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-01-19 20:31 UTC by Khaled Hosny
Modified: 2011-09-14 13:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
end-session-dialog: Use correct plural forms for timeouts (4.08 KB, patch)
2011-09-07 11:40 UTC, Florian Müllner 		none Details | Review
end-session-dialog: Use correct plural forms for timeouts (4.09 KB, patch)
2011-09-07 12:33 UTC, Florian Müllner 		committed Details | Review

Description Khaled Hosny 2011-01-19 20:31:46 UTC 
The following translatable strings require use of plural forms for proper l10n:

#: ../js/ui/endSessionDialog.js:66
#, c-format
msgid "%s will be logged out automatically in %d seconds."
msgstr ""

#: ../js/ui/endSessionDialog.js:67
#, c-format
msgid "You will be logged out automatically in %d seconds."
msgstr ""

See http://www.gnu.org/software/hello/manual/gettext/Plural-forms.html for more information about gettext plural forms.
Comment 1 Khaled Hosny 2011-01-19 20:36:56 UTC 
Also the following strings:

#: ../js/ui/endSessionDialog.js:76
#, fuzzy, c-format
msgid "The system will shut down automatically in %d seconds."
msgstr ""

#: ../js/ui/endSessionDialog.js:86
#, fuzzy, c-format
msgid "The system will restart automatically in %d seconds."
msgstr ""
Comment 2 Florian Müllner 2011-02-20 22:12:16 UTC 
*** Bug 642839 has been marked as a duplicate of this bug. ***
Comment 3 Florian Müllner 2011-09-07 11:40:39 UTC 
Created attachment 195856 [details] [review]
end-session-dialog: Use correct plural forms for timeouts

All end-session dialogs need to use ngettext for their timeout
strings, fix this.

Sorry for not getting to this before string break, however assuming quick review it shouldn't be hard to get a freeze break exception for this ...
Comment 4 Florian Müllner 2011-09-07 12:33:02 UTC 
Created attachment 195865 [details] [review]
end-session-dialog: Use correct plural forms for timeouts

Ooops, made a typo.
Comment 5 Dan Winship 2011-09-07 14:52:25 UTC 
Comment on attachment 195865 [details] [review]
end-session-dialog: Use correct plural forms for timeouts

ok... a bit messy having the Content structs be a mix of strings and functions, but...
Comment 6 André Klapper 2011-09-08 07:05:01 UTC 
Not having this fixed disallows proper sentences for many languages, so does anybody plan to ask for a string freeze break?
Comment 8 Florian Müllner 2011-09-14 13:46:00 UTC 
Attachment 195865 [details] pushed as a4eb3c1 - end-session-dialog: Use correct plural forms for timeouts

Pushed after freeze break approval.