GNOME Bugzilla – Bug 639958
Add MIME types to totem-pl-parser, for audio/x-ms-wma
Last modified: 2011-01-19 16:14:46 UTC
Attached patch that does this
Created attachment 178735 [details] [review] Patch that adds this MIME type
Created attachment 178736 [details] [review] Another patch with some more MIME types to add
Review of attachment 178735 [details] [review]: Where did you find a .wma file that was actually an ASF redirection?
Review of attachment 178736 [details] [review]: ::: plparse/totem-pl-parser.c @@ +200,3 @@ PLAYLIST_TYPE ("audio/x-ms-wax", totem_pl_parser_add_asx, NULL, FALSE), + PLAYLIST_TYPE ("application/x-ms-asx", totem_pl_parser_add_asx, NULL, FALSE), + PLAYLIST_TYPE ("audio/x-ms-asx", totem_pl_parser_add_asx, NULL, FALSE), Where do those mime-types come from?
Created attachment 178739 [details] File used while testing the patches
(In reply to comment #4) > Review of attachment 178736 [details] [review]: > > ::: plparse/totem-pl-parser.c > @@ +200,3 @@ > PLAYLIST_TYPE ("audio/x-ms-wax", totem_pl_parser_add_asx, NULL, FALSE), > + PLAYLIST_TYPE ("application/x-ms-asx", totem_pl_parser_add_asx, NULL, > FALSE), > + PLAYLIST_TYPE ("audio/x-ms-asx", totem_pl_parser_add_asx, NULL, FALSE), > > Where do those mime-types come from? No idea about this to be honest. That patch is one that we have been carrying around for longer and I need to check with a team-member how and why it was decided to add the MIME types this way.
(In reply to comment #3) > Review of attachment 178735 [details] [review]: > > Where did you find a .wma file that was actually an ASF redirection? I updated the test suite as well. (In reply to comment #6) <snip> > No idea about this to be honest. That patch is one that we have been carrying > around for longer and I need to check with a team-member how and why it was > decided to add the MIME types this way. video/x-ms-wvx is already an alias for audio/x-ms-asx, and I added application/x-ms-asx to shared-mime-info.